Fix table width #4380
Merged
Fix table width #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actual tables shouldn't be set to 100% by default. Add a config option so it's only applied to pull quote |
Actually we don't need a config option since we already have className which we can check against whether it's a multi line quote or not |
|
Classnames are for styling and you shouldn't be using them for anything else. If I could, I would write a lint rule not allowing to compare a classname using Use a separate prop like |
| @@ -53,6 +53,7 @@ describe('editor3.component.table-cell', () => { | |||
| it('should render', () => { | |||
| const wrapper = shallow( | |||
| <TableCell | |||
| fullWidth={{}} | |||
There was a problem hiding this comment.
how are you passing an empty object where a boolean is required?
tomaskikutis
approved these changes
Nov 16, 2023
thecalcc
merged commit 43f988f
into
superdesk:authoring-react-post-broadcasting
6 checks passed
dzonidoo
added a commit
to dzonidoo/superdesk-client-core
that referenced
this pull request
Nov 16, 2023
This reverts commit 43f988f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7116
I didn't find the ticket specific to this issue but we can consider it a part of the general fixes for multi-line quote