Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error message on delete #4378

Merged
merged 2 commits into from
Nov 16, 2023
Merged

show error message on delete #4378

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d493ca
show error message on delete
petrjasek Nov 14, 2023
14feab9
shorten code
petrjasek Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/core/helpers/crud-manager-http.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ export function connectCrudManagerHttp<Props, Entity extends IBaseRestApiRespons
.then(() => this.refresh())
.then(() => {
notify.success(gettext('The item has been deleted.'));
})
.catch((reason) => {
if (reason != null && reason.message != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also use a shorthand reason?.message != null instead

notify.error(reason.message);
return;
}

return Promise.reject(reason);
});
}

Expand Down
Loading