publish tab fix #4370
Merged
publish tab fix #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrjasek
reviewed
Nov 10, 2023
| @@ -48,7 +48,7 @@ export function AuthoringTopbarDirective( | |||
| dispatchInternalEvent('interactiveArticleActionStart', { | |||
| items: [scope.item], | |||
| tabs: ['send_to', 'publish'], | |||
| activeTab: 'publish', | |||
| activeTab: scope.item.flags.marked_for_not_publication ? 'send_to' : 'publish', | |||
There was a problem hiding this comment.
would use probably item.flags?.marked_... not sure if we have those flags set always
petrjasek
approved these changes
Nov 10, 2023
dzonidoo
merged commit 6805fb4
into
superdesk:authoring-react-post-broadcasting
2 of 3 checks passed
|
I was reviewing #4390 from @devketanpro and some questions about intended behavior came up which brought me to this PR - which seems incorrect @petrjasek. I was checking the JIRA ticket where it says that publish tab shouldn't be available in certain conditions. Then the primary thing we need to change is which tabs are available - set via I'll ask Ketan to improve it, posting here just to bring it to your attention Petr since you were reviewing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7079