Fix target subscribers loading in templates #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaskikutis
reviewed
Nov 7, 2023
| @@ -4,6 +4,7 @@ import {gettext} from 'core/utils'; | |||
| import {ToggleBox, FormLabel, TreeSelect} from 'superdesk-ui-framework/react'; | |||
| import {ControlledVocabulariesSelect} from './controlled-vocabulary-select'; | |||
| import {IArticle} from 'superdesk-api'; | |||
| import {render} from 'react-dom'; | |||
There was a problem hiding this comment.
you probably don't need this?
| @@ -1189,6 +1190,8 @@ export function MetadataService(api, subscribersService, vocabularies, $rootScop | |||
| _.each(items, (item) => { | |||
| self.values.customSubscribers.push({_id: item._id, name: item.name}); | |||
| }); | |||
|
|
|||
| window.dispatchEvent(new CustomEvent('metadata-loaded')); | |||
There was a problem hiding this comment.
Instead of dispatching an event here, call fetchSubscribers on componentDidMount. Also improve fetchSubscribers so it's cached - something like fetchCities.
There was a problem hiding this comment.
But it's not cities, it's subscribers
There was a problem hiding this comment.
I know it's not cities. I was suggesting to look at how caching is implemented in fetchCities
There was a problem hiding this comment.
Ok just re-read it yeah.
tomaskikutis
approved these changes
Nov 7, 2023
|
|
||
| </ToggleBox> | ||
| return this.state.loading === false && ( | ||
| <React.Fragment key={this.state.subscribers.length}> |
There was a problem hiding this comment.
no need for a key here since it's not being rendered in a list
thecalcc
merged commit 3728be0
into
superdesk:authoring-react-post-broadcasting
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7074