marked 'not for publication' invisible publish tab #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaskikutis
reviewed
Nov 7, 2023
| @@ -73,14 +73,16 @@ export class InteractiveArticleActionsPanel | |||
| const {activeTab} = this.state; | |||
| const markupV2 = authoringReactViewEnabled && this.props.markupV2 === true; | |||
| const handleUnsavedChanges = this.props.handleUnsavedChanges ?? handleUnsavedChangesDefault; | |||
| const item = items[0]; | |||
There was a problem hiding this comment.
Even though items[0] is used in multiple places it's not correct to declare it at the top of the scope, because you would confuse other developers on why are you checking only first item when this component supports multiple.
tomaskikutis
approved these changes
Nov 7, 2023
dzonidoo
merged commit 352a7a9
into
superdesk:authoring-react-post-broadcasting
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7079