fix publish schedule time picker #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid time conversion from local time to utc when saving. SDESK-7080
tomaskikutis
reviewed
Nov 7, 2023
scripts/core/utils.tsx
Outdated
| @@ -364,7 +365,14 @@ export function toQueryString( | |||
| * Output example: "1970-01-19T22:57:38" | |||
| */ | |||
| export function toServerDateFormat(date: Date): string { | |||
| return date.toJSON().slice(0, 19); | |||
| return moment(date).toISOString(true).slice(0, 19); | |||
There was a problem hiding this comment.
Why do you need moment here? Could you implement the same thing without it? We're creating a black box here by using moment that supports a thousand features and it's not clear which will be invoked here. You could also use a function from date-fns - those are much more explicit.
There was a problem hiding this comment.
I need something that won't change the time when converting it to ISO format, will check date-fns
There was a problem hiding this comment.
Looks like formatISO from date-fns does the job. It'd be good to add a comment also that this is your intention so someone who looks at it in the future understands why aren't you using the built-in ".toISOString"
tomaskikutis
approved these changes
Nov 8, 2023
petrjasek
merged commit a705b47
into
superdesk:authoring-react-post-broadcasting
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid time conversion from local time to utc when saving.
SDESK-7080