MacOS shortcut for links in editor3 #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaskikutis
approved these changes
Oct 23, 2023
| @@ -278,13 +278,22 @@ export class Editor3Component extends React.Component<IProps, IState> { | |||
| } | |||
| } | |||
|
|
|||
| isMacOS() { | |||
| if (navigator.userAgent.indexOf('Mac') != -1) { | |||
There was a problem hiding this comment.
Mac is a very short word and could trigger a false positive when found as a part of some other string https://www.thefreedictionary.com/words-containing-mac
You have it capitalized so it's a bit protected, but I'd rather convert to lower case and check if it includes "macintosh" or "mac os"
There was a problem hiding this comment.
I agree on your point, but userAgent isn't limitless in regards of what words it might contain. Most answers on the internet say you should check for the string "Mac". Why should I change it if that's the case?
| const selectionState = this.props.editorState.getSelection(); | ||
| const osBasedKeyRule = this.isMacOS() ? metaKey : ctrlKey; |
There was a problem hiding this comment.
keyboardModifier, mainModifier, modifierKey or modifier would be better choices for naming
| @@ -278,13 +278,22 @@ export class Editor3Component extends React.Component<IProps, IState> { | |||
| } | |||
| } | |||
|
|
|||
| isMacOS() { | |||
tomaskikutis
approved these changes
Oct 24, 2023
|
also fix CI |
petrjasek
pushed a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDNTB-851