Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGA sign off event listener #4339

Merged
merged 4 commits into from
Oct 11, 2023
Merged

TGA sign off event listener #4339

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71c14d6
TGA sign off event listener
thecalcc Oct 10, 2023
0e7ad3b
Add comment
thecalcc Oct 10, 2023
ccfa34b
Update comment
thecalcc Oct 10, 2023
fcd54af
Fix lint
thecalcc Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/apps/authoring/authoring/directives/AuthoringContainerDirective.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ export function AuthoringContainerDirective(authoringWorkspace: AuthoringWorkspa
scope: {},
require: 'sdAuthoringContainer',
link: function(scope, elem, attrs, ctrl) {
// Needed only for authoring Angular. In authoring react we have a generic
// event ('resource:updated') which listens to all item changes.
scope.$on('author_approval:updated', (event) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment for the record that it's handled through resource:updated event in authoring-react and this one is only needed for angular-based authoring? You should also test that it actually works on authoring react too even if it's not used yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Needed for authoring Angular.

"Only needed for authoring Angular." would be better phrasing.

if (event.item_id === scope.item._id) {
scope.item.extra.publish_sign_off = event.sign_off_new_data;
}
});

scope.$watch(authoringWorkspace.getState, (state) => {
if (state) {
if (itemInEditMode != null) {
Expand Down
Loading