Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : missing translate in h3 attribute #4327

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Fix : missing translate in h3 attribute #4327

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b424dd
Fix : missing translate in h3 attribute
devketanpro Sep 14, 2023
1db6cd7
addressed comment
devketanpro Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/apps/users/views/user-preferences.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<div class="preferences__content">
<ul class="simple-list simple-list--comfortable simple-list--fixedW-large simple-list--users">
<li class="simple-list__item simple-list__item--stacked simple-list__item--justify-flex-start">
<h3 id="feature-preview" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3">Feature preview</h3>
<h3 id="feature-preview" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3" translate>Feature preview</h3>
<div class="sd-container sd-container--flex sd-container--gap-none sd-container--direction-column sd-radius--medium sd-panel-bg--000 sd-shadow--z2 sd-padding--3 sd-state--focus sd-margin-b--1">
<ul class="simple-list simple-list--comfortable simple-list--dotted simple-list--no-border-b simple-list--no-border-t sd-padding--2">
<li class="simple-list__item simple-list__item--stacked">
Expand All @@ -40,7 +40,7 @@ <h3 id="feature-preview" class="sd-heading sd-text-align--left sd-text--sans sd-
</li>

<li class="simple-list__item simple-list__item--stacked simple-list__item--justify-flex-start">
<h3 id="view-formats" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3">View formats</h3>
<h3 id="view-formats" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3" translate>View formats</h3>
<div class="sd-container sd-container--flex sd-container--gap-none sd-container--direction-column sd-radius--medium sd-panel-bg--000 sd-shadow--z2 sd-padding--3 sd-state--focus sd-margin-b--1">
<p class="sd-text sd-text--normal sd-text-align--left sd-text--sans sd-text-color--light">Select the prefered default view format for specific areas of Superdesks interface. The sections
will always open in the selected view format, but can be always changed using the view option dropdown in each section.</p>
Expand Down Expand Up @@ -121,7 +121,7 @@ <h3 id="article-defaults" class="sd-heading sd-text-align--left sd-text--sans sd
</li>

<li class="simple-list__item simple-list__item--stacked simple-list__item--justify-flex-start" ng-hide="profileConfig.category === false">
<h3 id="prefered-categories" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3 sd-txt-transform--capitalize">{{ preferences['categories:preferred'].category }}</h3>
<h3 id="prefered-categories" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3 sd-txt-transform--capitalize" translate>{{ preferences['categories:preferred'].category }}</h3>
devketanpro marked this conversation as resolved.
Show resolved Hide resolved
<div class="sd-container sd-container--flex sd-container--gap-none sd-container--direction-column sd-radius--medium sd-panel-bg--000 sd-shadow--z2 sd-padding--3 sd-state--focus sd-margin-b--1">
<div sd-info-item>
<h4 class="sd-heading sd-text-align--left sd-text--sans sd-heading--h4 sd-margin-b--0-5">
Expand Down Expand Up @@ -163,7 +163,7 @@ <h4 class="sd-heading sd-text-align--left sd-text--sans sd-heading--h4 sd-margin
</li>

<li class="simple-list__item simple-list__item--stacked simple-list__item--justify-flex-start" ng-hide="profileConfig.desks === false">
<h3 id="prefered-desks" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3 sd-txt-transform--capitalize">{{ :: preferences['desks:preferred'].category }}</h3>
<h3 id="prefered-desks" class="sd-heading sd-text-align--left sd-text--sans sd-heading--h3 sd-txt-transform--capitalize" translate>{{ :: preferences['desks:preferred'].category }}</h3>
devketanpro marked this conversation as resolved.
Show resolved Hide resolved
<div class="sd-container sd-container--flex sd-container--gap-none sd-container--direction-column sd-radius--medium sd-panel-bg--000 sd-shadow--z2 sd-padding--3 sd-state--focus sd-margin-b--1">
<div sd-info-item>
<h4 class="sd-heading sd-text-align--left sd-text--sans sd-heading--h4 sd-margin-b--0-5">
Expand Down