Pin chrome version (#4690)

superdesk · Nov 25, 2024 · 10b6b86 · 10b6b86
1 parent 2c1f3ac
commit 10b6b86
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 23 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,79 +1,68 @@
 name: "CI"
-
 on:
   [push, pull_request]
-
 jobs:
-
   test:
-
     runs-on: ubuntu-latest
-
     steps:
     - uses: actions/checkout@v4
-
     - uses: actions/setup-node@v4
       with:
         node-version: '14.x'
-
     # avoid file watch limit error
     - run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
-
     - run: npm ci
     - run: npm run test || npm run test || npm run test
       env:
         TZ: "Europe/Prague"
-
   e2e:
     runs-on: ubuntu-latest
-
     strategy:
       fail-fast: false
       matrix:
         suite: [a, b]
-
     steps:
     - uses: actions/checkout@v4
-
     - uses: actions/setup-node@v4
       with:
         node-version: '14.x'
-
-
     - name: Start e2e server
       run: |
         docker compose pull
         docker compose build
         docker compose up -d
       working-directory: e2e/server
-
     - name: Build client
       run: npm install && npm run build && npm run specs--compile && npm run start-client-server
       working-directory: e2e/client
-
     # playwright start
-
     - name: Install Playwright Browsers
       run: npx playwright install --with-deps
       working-directory: e2e/client
-
     - name: Run Playwright tests
       run: npx playwright test
       working-directory: e2e/client
-
     - uses: actions/upload-artifact@v4
       if: ${{ failure() }}
       with:
         name: playwright-report-${{ matrix.suite }}
         path: e2e/client/test-results
-
     # playwright end
 
     # protractor start
+    - name: Setup Chrome
+      uses: browser-actions/setup-chrome@v1
+      id: setup-chrome
+      with:
+        chrome-version: 127.0.6533.99
+        install-dependencies: true
+        install-chromedriver: true
 
-    - name: Protractor
-      run: npx protractor-flake --parser standard  --max-attempts=3 -- protractor.conf.js --suite=${{ matrix.suite }}
+    - name: Run Protractor
+      run: npx protractor-flake --parser standard --max-attempts=3 -- protractor.conf.js --suite=${{ matrix.suite }}
       env:
+        CHROME_BIN: ${{ steps.setup-chrome.outputs.chrome-path }}
+        CHROMEWEBDRIVER: ${{ steps.setup-chrome.outputs.chromedriver-path }}
         TRAVIS: ci
         SCREENSHOTS_DIR: /tmp
       working-directory: e2e/client

diff --git a/e2e/client/protractor.conf.js b/e2e/client/protractor.conf.js
@@ -53,7 +53,7 @@ var config = {
 
     directConnect: true,
 
-    chromeDriver: process.env.CHROMEWEBDRIVER ? (process.env.CHROMEWEBDRIVER + '/chromedriver') : null,
+    chromeDriver: process.env.CHROMEWEBDRIVER ? process.env.CHROMEWEBDRIVER : null,
 
     onPrepare: function() {
         execSync(