Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STTNHUB-216] Agenda: Show group headers for hidden items #662

Merged
merged 17 commits into from
Nov 23, 2023
Merged

[STTNHUB-216] Agenda: Show group headers for hidden items #662

merged 17 commits into from
Nov 23, 2023

Conversation

MarkLark86
Copy link
Contributor

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

@MarkLark86 MarkLark86 added this to the v2.6 milestone Nov 20, 2023
petrjasek
petrjasek approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@petrjasek petrjasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me, was wondering why not fetch all the items with single query and only hide some in the UI?

assets/interfaces/configs.ts Outdated Show resolved Hide resolved
@MarkLark86
Copy link
Contributor Author

@petrjasek I have made the suggested changes, and reverted back to getting the items in 1 request.

@MarkLark86 MarkLark86 requested a review from petrjasek November 23, 2023 06:21
@MarkLark86 MarkLark86 merged commit 0dcad10 into superdesk:develop Nov 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrjasek petrjasek petrjasek approved these changes

@tomaskikutis tomaskikutis Awaiting requested review from tomaskikutis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkLark86 @petrjasek