feat: use microseconds for measuring pool checkouts #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abc3
approved these changes
Nov 21, 2024
chasers
approved these changes
Nov 21, 2024
hauleth
force-pushed
the
ft/use-microseconds-for-measuring-pool-checkouts
branch
3 times, most recently
from
2394c95 to
1e579f8
Compare
|
@chasers I have changed the metric name in Prometheus/VictoriaMetrics to include the unit, so it wouldn't be confused with "old" metrics, but it will require updates in the Grafana dashboards. |
chasers
approved these changes
Nov 28, 2024
hauleth
force-pushed
the
ft/use-microseconds-for-measuring-pool-checkouts
branch
from
1e579f8 to
fa53010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently we measure pools checkouts in milliseconds, but these do not give us enough resolution and almost everything is crammed into
le="1"bucket.What is the new behavior?
Change time unit used for measures to microsecond so all measurements are multiplied by factor of
1000which should give us better insights into real distribution.