Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pre-commit-config.yaml #132

Merged
merged 8 commits into from
May 8, 2024
Merged

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Update .pre-commit-config.yaml to use the latest versions of hooks.

@juancarlospaco juancarlospaco requested a review from a team as a code owner May 4, 2024 00:50
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juancarlospaco - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment on lines +46 to +48
skip_types = (
options.get("skip_types") if options.get("skip_types") == "undefined" else []
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_clarification): Consider simplifying the conditional logic for clarity.

The current nested use of options.get within the conditional and ternary operator can be simplified for better readability and maintainability.

Suggested change
skip_types = (
options.get("skip_types") if options.get("skip_types") == "undefined" else []
)
skip_types = options.get("skip_types", [])
if skip_types == "undefined":
skip_types = []

@silentworks
Copy link
Contributor

Cannot merge this as it seems to update more than just .pre-commit-config.yaml. Please correct this and I'll review the PR after.

@juancarlospaco
Copy link
Contributor Author

But it is intended, otherwise the updated linters will error out on the imperfections in the code,
it is the suggested code that the linters recommend when run, it fails without those changes basically,
it is removing trailing whitespace, sorting imports alphabetically, etc very common harmless changes.

@J0 J0 merged commit 8bcf6da into supabase:master May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants