-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .pre-commit-config.yaml #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @juancarlospaco - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
skip_types = ( | ||
options.get("skip_types") if options.get("skip_types") == "undefined" else [] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_clarification): Consider simplifying the conditional logic for clarity.
The current nested use of options.get
within the conditional and ternary operator can be simplified for better readability and maintainability.
skip_types = ( | |
options.get("skip_types") if options.get("skip_types") == "undefined" else [] | |
) | |
skip_types = options.get("skip_types", []) | |
if skip_types == "undefined": | |
skip_types = [] |
Cannot merge this as it seems to update more than just .pre-commit-config.yaml. Please correct this and I'll review the PR after. |
But it is intended, otherwise the updated linters will error out on the imperfections in the code, |
What kind of change does this PR introduce?
.pre-commit-config.yaml
to use the latest versions of hooks.