Functions returning view type must have pkey (et.al.) #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olirice
commented
Jan 3, 2024
| @@ -807,7 +807,7 @@ begin; | |||
| rollback to savepoint a; | |||
|
|
|||
| create table account( | |||
| id int, | |||
| id int primary key, | |||
There was a problem hiding this comment.
I had to add this to make the test valid since we require primary keys
| create function returns_null_account() | ||
| returns account language sql stable | ||
| as $$ select id, email, name from account where id = 9; $$; | ||
|
|
||
| insert into account(id, email, name) | ||
| values | ||
| (1, '[email protected]', 'aardvark'),--all columns non-null | ||
| (2, '[email protected]', null),--mixed: some null, some non-null | ||
| (null, null, null);--all columns null |
There was a problem hiding this comment.
after adding the pkey constraint, this record is no longer valid.
Since require a pkey I don't think it's necessary/possible to test for this case because can't happen. right?
imor
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function returns a view's type and that view is
selectablebut does not have a primary key (a requirement to be present in the schema), the function contains an invalid type reference. This PR resolves that issue by requiring that all the requirements for a table/view to be included in the __Schema are met before allowing it to be returned by a function in the __SchemaThis is another attempt at #477 which mirrors the logic in __Schema exactly rather than checking a subset of requirements.
The intended goal is to avoid invalid references caused by functions returning types that aren't present in the schema.
Resolves #481