Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add SSO via OIDC #1732

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

WIP: Add SSO via OIDC #1732

wants to merge 5 commits into from

Conversation

smndtrl
Copy link

@smndtrl smndtrl commented Aug 21, 2024

What kind of change does this PR introduce?

SSO via OIDC in additional to SAML

What is the current behavior?

SSO only with SAML

What is the new behavior?

SSO with SAML or OIDC possible

Additional context

This is a WIP! Not all necessary functionality is in there.

The GenericProvider was taken from @carlobeltrame PR #1372

@hf
Copy link
Contributor

hf commented Sep 2, 2024

Wow! Ideally we'd want this to be built by the team, but if you want to continue developing it we can have a sync some time?

@smndtrl
Copy link
Author

smndtrl commented Sep 4, 2024

@hf Feel free to take of the code what you want/need depending on your level of NIH. There is no real novel code to begin with as I made an effort to reuse as much of the existing code paths as possible.

I'm running my modified version on-top of a hosted supabase instance and that's all I needed for now. I did it mostly to re-familiarize myself with all the OIDC flows, state keeping, etc... For a lot of things I'm working on auth has made decisions that are too opinionated to be used further down the line.

@nietsmmar
Copy link

Wow! Ideally we'd want this to be built by the team, but if you want to continue developing it we can have a sync some time?

I heard (some months back). that this is actually on the Roadmap. Are there any more details on when this will be implemented? It is quite crucial for us to be able to use some specific OIDC providers. With supabase not supporting this, this is a big flaw for us. We would really appreciate to have this feature.

Thanks for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants