Improvements based on feedback from Analyze build. Added CFRelease st…

…atements on address and addresses value refs in SFLocalLegislatorsViewController. Corrected BOOL pointer assignment blocks in SFCommitteeSegmentedViewController, etc. Added super calls for viewDidLoad and viewWillAppear: overrides. Removed some unused variables.

Classes/Controllers/SFActivitySectionViewController.m

@@ -190,6 +190,7 @@ - (void)viewDidLoad {
 }
 
 - (void)viewDidAppear:(BOOL)animated {
+    [super viewDidAppear:animated];
     /*
        BOOL isFollowingObjects = ([[self _getFollowedObjects] count] > 0);
        CGRect contentRect = [self.view convertRect:_segmentedVC.segmentedView.contentView.frame fromView:_segmentedVC.segmentedView];

Classes/Controllers/SFBillDetailViewController.m

@@ -55,6 +55,7 @@ - (void)loadView {
 }
 
 - (void)viewDidLoad {
+    [super viewDidLoad];
     [_billDetailView.linkOutButton addTarget:self action:@selector(handleLinkOutPress) forControlEvents:UIControlEventTouchUpInside];
     [_billDetailView.sponsorButton addTarget:self action:@selector(handleSponsorPress) forControlEvents:UIControlEventTouchUpInside];
     [_billDetailView.cosponsorsButton addTarget:self action:@selector(handleCosponsorsPress) forControlEvents:UIControlEventTouchUpInside];

Classes/Controllers/SFBillSegmentedViewController.m

@@ -169,7 +169,7 @@ - (void)setVisibleSegment:(NSString *)segmentName;
 {
     NSUInteger segmentIndex = [_segmentedVC.segmentTitles indexOfObjectPassingTest: ^BOOL (id obj, NSUInteger idx, BOOL *stop) {
         if ([segmentName caseInsensitiveCompare:(NSString *)obj] == NSOrderedSame) {
-            stop = YES;
+            *stop = YES;
             return YES;
         }
         return NO;

Classes/Controllers/SFCommitteeMembersTableViewController.m

@@ -29,6 +29,7 @@ - (void)viewDidAppear:(BOOL)animated {
     id <GAITracker> tracker = [[GAI sharedInstance] defaultTracker];
     [tracker set:kGAIScreenName value:@"Committee Member List Screen"];
     [tracker send:[[GAIDictionaryBuilder createAppView] build]];
+    [super viewDidAppear:animated];
 }
 
 #pragma mark - UITableViewDelegate

Classes/Controllers/SFCommitteeSegmentedViewController.m

@@ -173,7 +173,7 @@ - (void)updateWithCommittee:(SFCommittee *)committee {
 - (void)setVisibleSegment:(NSString *)segmentName {
     NSUInteger segmentIndex = [_segmentTitles indexOfObjectPassingTest: ^BOOL (id obj, NSUInteger idx, BOOL *stop) {
         if ([segmentName caseInsensitiveCompare:(NSString *)obj] == NSOrderedSame) {
-            stop = YES;
+            *stop = YES;
             return YES;
         }
         return NO;

Classes/Controllers/SFCommitteesSectionViewController.m

@@ -73,13 +73,15 @@ - (void)viewDidLoad {
 
 - (void)viewWillAppear:(BOOL)animated {
     [self update];
+    [super viewWillAppear:animated];
 }
 
 - (void)viewDidAppear:(BOOL)animated {
     if (_restorationSelectedSegment != nil) {
         [_segmentedController displayViewForSegment:_restorationSelectedSegment];
         _restorationSelectedSegment = nil;
     }
+    [super viewDidAppear:animated];
 }
 
 - (void)didReceiveMemoryWarning {

Classes/Controllers/SFHearingsSectionViewController.m

@@ -72,13 +72,15 @@ - (void)viewDidLoad {
 
 - (void)viewWillAppear:(BOOL)animated {
     [self update];
+    [super viewWillAppear:animated];
 }
 
 - (void)viewDidAppear:(BOOL)animated {
     if (_restorationSelectedSegment != nil) {
         [_segmentedController displayViewForSegment:_restorationSelectedSegment];
         _restorationSelectedSegment = nil;
     }
+    [super viewDidAppear:animated];
 }
 
 - (void)update {

Classes/Controllers/SFLegislatorDetailViewController.m

@@ -110,6 +110,7 @@ - (void)loadView {
 }
 
 - (void)viewDidLoad {
+    [super viewDidLoad];
     [_legislatorDetailView.followButton sam_setTarget:self action:@selector(handleFollowButtonPress) forControlEvents:UIControlEventTouchUpInside];
     _legislatorDetailView.followButton.selected = NO;
 
@@ -286,7 +287,7 @@ - (void)updateView {
 - (void)handleSocialButtonPress:(id)sender {
     NSString *senderKey = [[_socialButtons keysOfEntriesPassingTest: ^BOOL (id key, id obj, BOOL *stop) {
             if ([obj isEqual:sender]) {
-                stop = YES;
+                *stop = YES;
                 return YES;
             }
             return NO;

Classes/Controllers/SFLegislatorSegmentedViewController.m

@@ -98,6 +98,7 @@ - (void)viewDidAppear:(BOOL)animated {
         [self setLegislatorWithBioguideId:_restorationBioguideId];
         _restorationBioguideId = nil;
     }
+    [super viewDidAppear:animated];
 }
 
 - (void)didReceiveMemoryWarning {
@@ -208,7 +209,7 @@ - (void)setLegislator:(SFLegislator *)legislator {
 - (void)setVisibleSegment:(NSString *)segmentName {
     NSUInteger segmentIndex = [self.segmentTitles indexOfObjectPassingTest: ^BOOL (id obj, NSUInteger idx, BOOL *stop) {
         if ([segmentName caseInsensitiveCompare:(NSString *)obj] == NSOrderedSame) {
-            stop = YES;
+            *stop = YES;
             return YES;
         }
         return NO;

Classes/Controllers/SFLocalLegislatorsViewController.m

@@ -229,8 +229,9 @@ - (void)viewDidAppear:(BOOL)animated {
     }
 }
 
-- (void)viewDidDisappear:(BOOL)animatedd {
+- (void)viewDidDisappear:(BOOL)animated {
     [_locationManager stopUpdatingLocation];
+    [super viewDidDisappear:animated];
 }
 
 - (void)setupLayoutConstraints {
@@ -564,6 +565,9 @@ - (BOOL)peoplePickerNavigationController:(ABPeoplePickerNavigationController *)p
 
     [self moveAnnotationToAddress:(__bridge NSDictionary *)(address) andRecenter:YES];
 
+    CFRelease(addresses);
+    CFRelease(address);
+
     return NO;
 }
 

Classes/Controllers/SFVoteDetailViewController.m

@@ -93,6 +93,7 @@ - (void)loadView {
 }
 
 - (void)viewDidLoad {
+    [super viewDidLoad];
     self.edgesForExtendedLayout = UIRectEdgeNone;
     _voteDetailView = [[SFVoteDetailView alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
     _voteDetailView.translatesAutoresizingMaskIntoConstraints = NO;

Classes/Style/SFCongressAppStyle.m

@@ -295,14 +295,12 @@ + (CGFloat)lineSpacing {
 @implementation SFCongressAppStyle
 
 + (void)setUpGlobalStyles {
-    NSInteger statusBarStyleValue;
     UITableView *tableViewStyle = [UITableView appearance];
     tableViewStyle.sectionIndexColor = [UIColor primaryTextColor];
 
     __weak UIWindow *window = [UIApplication sharedApplication].keyWindow;
     window.backgroundColor = [UIColor primaryBackgroundColor];
 
-    statusBarStyleValue = UIStatusBarStyleLightContent;
     tableViewStyle.sectionIndexBackgroundColor = [UIColor clearColor];
     window.tintColor = [UIColor defaultTintColor];
 

Classes/Transformers/SFDefaultBillCellTransformer.m

@@ -45,11 +45,7 @@ - (id)transformedValue:(id)value {
         [dateFormatter setDateStyle:NSDateFormatterMediumStyle];
         [dateFormatter setTimeStyle:NSDateFormatterNoStyle];
 
-        NSString *lastAction = [NSString stringWithFormat:@"%@ on %@",
-                                bill.lastAction.typeDescription,
-                                [dateFormatter stringFromDate:bill.lastActionAt]];
-
-        lastAction = bill.lastAction.text;
+        NSString *lastAction = bill.lastAction.text;
 
         cellData.detailTextLabelString = lastAction;
         cellData.detailTextLabelNumberOfLines = 3;

Classes/Views/SFTableCell.m

@@ -137,11 +137,6 @@ - (void)layoutSubviews {
     if (self.height < self.cellHeight) self.height = ceilf(self.cellHeight);
     self.contentView.height = ceilf(self.cellHeight);
 
-    CGFloat pTop = floorf(self.textLabel.bottom);
-    if (self.detailTextLabel) {
-        pTop = floorf(self.detailTextLabel.bottom);
-    }
-
     _cellHighlightImage.top = 0;
     _cellHighlightImage.height = self.height - 1;