Apply sumcheck to nonzero constraints directly #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added concatenated balance for nonzero constraint process * fix: order of assigning balance value following the order of concatenated balance * fixing typo * Fix selector and concatenated balance on nonzero-constrain * fix typo * fix: following review comments * fix: added assertions for N_CURRENCIES in the gate * fix: gh workflow
|
Looks good! Let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see summa-dev/plonkish#2 to understand how the "nonzero" gate is handled in the modified plonkish backend. TLDR:
a simple gate that is querying the balance like
meta.query_advice(balance, Rotation::cur())will add all the cells to sumcheck without the need for rotations, and the final sumcheck (which is actually a zero check in hyperplonk) will pass (3 + 5 -8 =0).