Update benchmark for v1-improvement #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sifnoc
requested review from
enricobottazzi and
alxkzmn
and removed request for
enricobottazzi
enricobottazzi
requested changes
Dec 11, 2023
zk_prover/benches/utils.rs
Outdated
| @@ -0,0 +1,18 @@ | |||
| extern crate proc_macro; | |||
There was a problem hiding this comment.
What is this utils doing? And where is this being used?
There was a problem hiding this comment.
It's leftover, removed at 298e83e
zk_prover/README.md
Outdated
| wget https://summa-solvency.s3.eu-central-1.amazonaws.com/csv_files.tar.bz2 | ||
| tar -xjf csv_files.tar.bz2 | ||
| ```bash | ||
| mkdir -p benche/csv |
zk_prover/README.md
Outdated
| mkdir -p benche/csv | ||
| cd benche/csv | ||
| wget https://summa-solvency.s3.eu-central-1.amazonaws.com/1_entry_2_20.zip | ||
| unzip sample_csv_files_for_bench.zip |
There was a problem hiding this comment.
error here
unzip: cannot find or open sample_csv_files_for_bench.zip, sample_csv_files_for_bench.zip.zip or sample_csv_files_for_bench.zip.ZIP.
zk_prover/test.sh
Outdated
| @@ -0,0 +1,9 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Do we need to maintain this file?
There was a problem hiding this comment.
It's leftover, removed at 298e83e
sifnoc
force-pushed
the
v1-improvements-fix-bench
branch
from
f1974b4 to
298e83e
Compare
|
Re open this PR as "Fixed benchmark for v1-improvement" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #197: