Mantainance #202
Merged
Mantainance #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 1, 2023
Closed
alxkzmn
reviewed
Dec 1, 2023
| let mut max_balance = max_value.clone(); | ||
|
|
||
| // Perform the summation for each level up the Merkle Root | ||
| for _ in 0..n_levels { |
There was a problem hiding this comment.
Can be replaced by a product
alxkzmn
reviewed
Dec 1, 2023
zk_prover/src/chips/range/tests.rs
Outdated
| @@ -103,6 +103,32 @@ struct TestCircuit<const N_BYTES: usize> { | |||
| pub b: Fp, | |||
| } | |||
|
|
|||
| impl<const N_BYTES: usize> TestCircuit<N_BYTES> { | |||
There was a problem hiding this comment.
My fault, haven't noticed this while reviewing the previous PR. Since there's actually some common code shared between different circuits, it can stay in CircuitBase 😄
alxkzmn
approved these changes
Dec 1, 2023
sifnoc
approved these changes
Dec 1, 2023
sifnoc
approved these changes
Dec 1, 2023
enricobottazzi
merged commit c2a3ee2
into
v1-improvements-and-consolidation
6 checks passed
alxkzmn
pushed a commit
to alxkzmn/summa-solvency
that referenced
this pull request
Dec 5, 2023
alxkzmn
pushed a commit
to alxkzmn/summa-solvency
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
LEVELSandN_BYTESpossible overflow combination insidegen_verifier#201N_ASSETSnaming #200signatures.csvout ofapifolder inbackend#196As consequence of that
csvfiles folder for Benchmark #197N_ASSETSfix naming summa-aggregation#9