Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OOM while building MST #164

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fix OOM while building MST #164

merged 3 commits into from
Oct 26, 2023

Conversation

sifnoc
Copy link
Member

@sifnoc sifnoc commented Oct 23, 2023

There is OOM when build Merkle some tree that has more than 2^27 elements due to no limit on the thread.
We can apply Rayon for multi-threading instead of thread.

@enricobottazzi
Copy link
Member

LGTM! Can you please just update the README with the new benchmarks results (I noticed you modified from 2 assets to 1 assets)

@alxkzmn alxkzmn merged commit ffd8259 into master Oct 26, 2023
4 checks passed
@enricobottazzi enricobottazzi deleted the fix-benchmark branch November 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricobottazzi enricobottazzi enricobottazzi approved these changes

@alxkzmn alxkzmn alxkzmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sifnoc @enricobottazzi @alxkzmn