Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More examples in the backend #159

Merged
merged 12 commits into from
Sep 26, 2023
Merged

More examples in the backend #159

merged 12 commits into from
Sep 26, 2023

Conversation

sifnoc
Copy link
Member

@sifnoc sifnoc commented Sep 19, 2023 •
edited
Loading

Related issue: #128

Major changes in the Backend:

  • By default, the inclusion proof in the Round is now generated using the gen_evm_proof_shplonk method.
  • Introduced full_evm_verifier to verify inclusion proofs created with gen_evm_proof_shplonk.

@sifnoc sifnoc marked this pull request as ready for review September 20, 2023 13:11
@sifnoc sifnoc requested review from alxkzmn and enricobottazzi and removed request for alxkzmn September 20, 2023 13:12
alxkzmn
alxkzmn requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not necessary to use a ";" as a delimiter in the CSV.

backend/README.md Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
backend/examples/generate_signatures.rs Outdated Show resolved Hide resolved
enricobottazzi
enricobottazzi requested changes Sep 22, 2023
View reviewed changes
backend/examples/mock_signer.rs Outdated Show resolved Hide resolved
backend/examples/generate_signatures.rs Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
backend/README.md Outdated Show resolved Hide resolved
zk_prover/src/circuits/utils.rs Outdated Show resolved Hide resolved
zk_prover/src/circuits/utils.rs Outdated Show resolved Hide resolved
backend/examples/helpers/inclusion_proof.rs Outdated Show resolved Hide resolved
backend/examples/helpers/inclusion_proof.rs Outdated Show resolved Hide resolved
backend/examples/verify_inclusion_on_local.rs Outdated Show resolved Hide resolved
@enricobottazzi
Copy link
Member

@sifnoc Can you also add the test of the examples to the workflow?

Similar to this => https://github.com/summa-dev/summa-solvency/blob/master/.github/workflows/rust.yml#L27-L30

@sifnoc
Copy link
Member Author

sifnoc commented Sep 25, 2023

@sifnoc Can you also add the test of the examples to the workflow?

Added! 1971fbf

enricobottazzi
enricobottazzi approved these changes Sep 26, 2023
View reviewed changes
backend/README.md
```

On successful execution, you'll observe a message indicating the verification outcome:

### 2. Submit Proof of Solvency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify that the goal of the proof of solvency is also to check that the assets controlled by the exchange are greater than the liabilities (as committed in the Merkle Sum Tree Root Hash)

@sifnoc sifnoc merged commit f11d633 into master Sep 26, 2023
4 checks passed
@sifnoc sifnoc deleted the more-backend-examples branch September 26, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricobottazzi enricobottazzi enricobottazzi approved these changes

@alxkzmn alxkzmn alxkzmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sifnoc @enricobottazzi @alxkzmn