Feat Nova incremental inclusion verification #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricobottazzi
changed the title
sifnoc
reviewed
Sep 12, 2023
alxkzmn
reviewed
Sep 12, 2023
| right_in_range[i] = Num2Bits(8*N_BYTES); | ||
|
|
||
| left_in_range[i].in <== left_balances[i]; | ||
| right_in_range[i].in <== right_balances[i]; |
There was a problem hiding this comment.
Is it enough to just assign the inputs of Num2Bits without checking the output?
There was a problem hiding this comment.
Copying from internal discussion
"My understanding is that to perform range check on a number we don’t really have to consume the output, we just want to check that the number can be expressed in a specific bit range. So if the number doesn’t fit this assertion will fail => https://github.com/iden3/circomlib/blob/master/circuits/bitify.circom#L38"
You can also reproduce this on ZKREPL by following this gist.
sifnoc
approved these changes
Sep 13, 2023
alxkzmn
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example of how a full flow of Incremental Proof of Inclusion verification can be performed using Nova as a prover. A more detailed explanation can be found in Incremental Inclusion Verfication.
zk_prover/circom, contains the circuit implementation for the nova prover + some template circuits from circomlibexamples/nova_incremental_verifier.rscontains the script to run the exampleexamples/buildcontains thewasmandr1csartifacts automatically generated by circom after the circuit compilation.As you will see in the example script, I had to add different support functions related to the Merkle Sum Tree. The issue comes from the fact that the Poseidon Hasher used in circomlib behaves differently from our own implementation of the Poseidon Hasher so I couldn't use our
MerkleSumTreestruct. Luckily I found a rust library poseidon-rs that is compatible with circom's posiedon. Unfortunately, I meant recreating all the utils with this different hasher.If we decide to move forward with this implementation, we need to find a way to create compatibility between the 2 hashers.