Fix linting errors (#250)

sulu · Jun 1, 2023 · d5a6cdf · d5a6cdf
1 parent 890f158
commit d5a6cdf
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 7 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -31,6 +31,8 @@
         'single_line_throw' => false,
         'strict_comparison' => true,
         'strict_param' => true,
+        'get_class_to_class_keyword' => false, // should be enabled as soon as support for php < 8 is dropped
+        'nullable_type_declaration_for_default_null_value' => true,
     ])
     ->setFinder(
         PhpCsFixer\Finder::create()

diff --git a/Content/Domain/Model/ShadowTrait.php b/Content/Domain/Model/ShadowTrait.php
@@ -23,7 +23,7 @@ trait ShadowTrait
     /**
      * @var string[]|null
      */
-    protected $shadowLocales = null;
+    protected $shadowLocales;
 
     /**
      * @internal should only be set by content bundle services not from outside

diff --git a/Content/Infrastructure/Sulu/Search/ContentReindexProvider.php b/Content/Infrastructure/Sulu/Search/ContentReindexProvider.php
@@ -57,7 +57,7 @@ class ContentReindexProvider implements LocalizedReindexProviderInterface
     /**
      * @var class-string<B>|null
      */
-    private $dimensionContentClass = null;
+    private $dimensionContentClass;
 
     /**
      * @param class-string<T> $contentRichEntityClass

diff --git a/Content/Infrastructure/Sulu/Search/ContentSearchMetadataProvider.php b/Content/Infrastructure/Sulu/Search/ContentSearchMetadataProvider.php
@@ -74,7 +74,7 @@ class ContentSearchMetadataProvider implements ProviderInterface
     /**
      * @var class-string<B>|null
      */
-    private $dimensionContentClass = null;
+    private $dimensionContentClass;
 
     /**
      * @param class-string<T> $contentRichEntityClass

diff --git a/Content/Infrastructure/Sulu/SmartContent/Provider/ContentDataProvider.php b/Content/Infrastructure/Sulu/SmartContent/Provider/ContentDataProvider.php
@@ -41,7 +41,7 @@ public function __construct(
         DataProviderRepositoryInterface $repository,
         ArraySerializerInterface $arraySerializer,
         ContentManagerInterface $contentManager,
-        ReferenceStoreInterface $referenceStore = null
+        ?ReferenceStoreInterface $referenceStore = null
     ) {
         parent::__construct($repository, $arraySerializer);
 

diff --git a/Tests/Application/ExampleTestBundle/Exception/ExampleNotFoundException.php b/Tests/Application/ExampleTestBundle/Exception/ExampleNotFoundException.php
@@ -30,7 +30,7 @@ class ExampleNotFoundException extends \Exception
     /**
      * @param mixed[] $filters
      */
-    public function __construct(array $filters, int $code = 0, \Throwable $previous = null)
+    public function __construct(array $filters, int $code = 0, ?\Throwable $previous = null)
     {
         $this->model = Example::class;
 

diff --git a/Tests/Functional/Content/Infrastructure/Sulu/Teaser/ContentTeaserProviderTest.php b/Tests/Functional/Content/Infrastructure/Sulu/Teaser/ContentTeaserProviderTest.php
@@ -162,7 +162,7 @@ public function testFindENNoRoute(): void
     }
 
     /**
-     * @param Teaser[]$teasers
+     * @param Teaser[] $teasers
      *
      * @return array<string, mixed>
      */

diff --git a/Tests/Unit/Content/Infrastructure/Sulu/Admin/ContentViewBuilderFactoryTest.php b/Tests/Unit/Content/Infrastructure/Sulu/Admin/ContentViewBuilderFactoryTest.php
@@ -55,7 +55,7 @@ class ContentViewBuilderFactoryTest extends TestCase
     protected function createContentViewBuilder(
         ContentMetadataInspectorInterface $contentMetadataInspector,
         SecurityCheckerInterface $securityChecker,
-        PreviewObjectProviderRegistryInterface $previewObjectProviderRegistry = null,
+        ?PreviewObjectProviderRegistryInterface $previewObjectProviderRegistry = null,
         array $settingsForms = []
     ): ContentViewBuilderFactoryInterface {
         if (null === $previewObjectProviderRegistry) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -162,7 +162,7 @@ public function testFindENNoRoute(): void @@
         }
         /**
-         * @param Teaser[]$teasers
+         * @param Teaser[] $teasers
          *
          * @return array<string, mixed>
          */
@@ Expand Down @@