Remove baseline

sulu · Sep 29, 2023 · d0f6624 · d0f6624
1 parent 54d620e
commit d0f6624
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 80 deletions.
diff --git a/Entity/Comment.php b/Entity/Comment.php
@@ -31,7 +31,7 @@ class Comment implements CommentInterface, AuditableInterface
     protected $state = self::STATE_PUBLISHED;
 
     /**
-     * @var string
+     * @var string|null
      */
     protected $message;
 
@@ -61,7 +61,7 @@ class Comment implements CommentInterface, AuditableInterface
     protected $parent;
 
     /**
-     * @var Collection|CommentInterface[]
+     * @var Collection<int, CommentInterface>|CommentInterface[]
      */
     protected $children;
 

diff --git a/Entity/Thread.php b/Entity/Thread.php
@@ -47,7 +47,7 @@ class Thread implements ThreadInterface, AuditableInterface
     protected $commentCount = 0;
 
     /**
-     * @var Collection
+     * @var Collection<int, CommentInterface>
      */
     protected $comments;
 
@@ -71,6 +71,9 @@ class Thread implements ThreadInterface, AuditableInterface
      */
     protected $creator;
 
+    /**
+     * @param Collection<int, CommentInterface>|null $comments
+     */
     public function __construct(string $type, string $entityId, Collection $comments = null, int $commentCount = 0)
     {
         $this->type = $type;

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
diff --git a/phpstan.neon b/phpstan.neon
@@ -6,7 +6,6 @@ includes:
     - vendor/phpstan/phpstan-phpunit/extension.neon
     - vendor/phpstan/phpstan-phpunit/rules.neon
     - vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon
-    - phpstan-baseline.neon
 
 parameters:
     paths:
@@ -21,3 +20,6 @@ parameters:
         console_application_loader: Tests/phpstan/console-application.php
     doctrine:
         objectManagerLoader: Tests/phpstan/object-manager.php
+    ignoreErrors:
+        - "#^Property .* type mapping mismatch\\: property can contain .* but database .*$#"
+        - "#^Property .* type mapping mismatch\\: database can contain .* but property .*$#"