Adds validation that page_range can only be up to 30 characrters #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…illiad database record field length
|
Working with Atlas, we fixed the API error that happens when the page range field is more than 30 chars. However, it does truncate the field, so any extraneous information that the user enters here will be lost. In a different PR we should consider adding some kind of a note field because requestors often add additional information about the page range. |
|
I recently upgraded to ILLiad 9.2 and the PhotoJournalInclusivePages field is still only 30 characters. |
|
Is this still a problem in Illiad or can we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The illiad database record field length for PhotoJournalInclusivePages can currently only handle up to 30 chars. They will be fixing this sometime in the near-ish future, but in the meantime this will prevent failed illiad api transaction requests and the email being sent to ILB.
N.b. If we are OK with just getting the occasional (but sometimes daily) error we can consider foregoing this change, as we might then want to back it out when Atlas fixes the field length in the next version upgrade. I have no idea how long it will be before they release a new version upgrade.