New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filename to be provided #139

Open

jcoyne opened this issue Nov 2, 2020 · 0 comments

Contributor

jcoyne commented Nov 2, 2020 •

edited

Loading

sdr-client/lib/sdr_client/deposit/upload_files.rb

Line 35 in d75f507

file_name = ::File.basename(path)

This allows us to upload with a friendly looking name, even if the local file is not what we want in the repo.

We are currently working around this via: https://github.com/sul-dlss/happy-heron/blob/main/app/jobs/deposit_job.rb#L48-L55. But perhaps there is a better way?

mjgiarlo assigned mjgiarlo and unassigned mjgiarlo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment