-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instead of sending audit outcomes to workflow service, just expose status via REST endpoint #1249
Comments
only index it if we are doing something more than having this display for an object at API endpoint (part of /objects/druid or separately) |
Note that however audit outcomes are exposed, we want the DETAILS of the audits -- WHY did it fail? This might be best handled by adding a status_details field to complete_moab and to zip_parts. Note that field size is finite, and we've run into zip_part audits sending too much text to workflow-service, so we would want to avoid this #1240. It might be addressed by having each zip part get its own status details.
|
I just barely started this work. It is is the audit-status-in-db branch. |
closing -- i think #1363 covers this ground better |
reporting audit results to workflow server was always a hack for development expediency, because we thought it'd be a faster way (in terms of development time) to expose audit results to argo users. however, this mechanism has been brittle in a number of unexpected ways, and it seems like it would be better to:
CompleteMoab
s andZipPart
s (and whatever else) via REST (e.g. caller could hit pres cat with a given druid, and relevant status info etc for Moab(s) and archive copies could be returned).archived
,unreplicated
,some_parts_not_found
, etc).to help reduce worry about breaking the existing reporting functionality, we could implement the indexing, let the two approaches live side by side for a bit, and then get rid of the workflow reporting.
codebases that this would touch:
preservationAuditWF
doing this would obviate the need for #1240, since we'd no longer need the workflow reporting mechanism at all.
The text was updated successfully, but these errors were encountered: