Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED by #1986] figure out how to re-enable zip part audit codes in AuditResults::WORKFLOW_REPORT_CODES #1240

Open
jmartin-sul opened this issue Nov 18, 2019 · 3 comments

Comments

@jmartin-sul
Copy link
Member

jmartin-sul commented Nov 18, 2019

see

# Temporary fix for workflow-service throwing exceptions
# because some error reports from MoabReplicationAudit are too long
# ZIP_PART_CHECKSUM_MISMATCH,
# ZIP_PART_NOT_FOUND,
# ZIP_PARTS_COUNT_DIFFERS_FROM_ACTUAL,
# ZIP_PARTS_COUNT_INCONSISTENCY,
# ZIP_PARTS_NOT_ALL_REPLICATED

this way, replication errors are surfaced in argo the same way as other errors are, and block further versioning of problematic druids.

i wasn't sure whether to count this as a bug, or tech debt, so i counted it as both 😆

@jmartin-sul jmartin-sul changed the title figure out how to re-enable zip part audit codes in AuditResults::WORKFLOW_REPORT_CODES [HOLD] figure out how to re-enable zip part audit codes in AuditResults::WORKFLOW_REPORT_CODES Dec 9, 2019
@jmartin-sul
Copy link
Member Author

jmartin-sul commented Dec 9, 2019

#1249 might obviate the need for this. or not, if we want want replication errors to halt further versioning for a druid.

@jmartin-sul
Copy link
Member Author

i think we still want this, and iirc, the reason we disabled the codes was because the error messages would exceed some field length or other when workflow service's database was still in oracle (it was later migrated to postgres).

removing [HOLD]

@jmartin-sul jmartin-sul changed the title [HOLD] figure out how to re-enable zip part audit codes in AuditResults::WORKFLOW_REPORT_CODES figure out how to re-enable zip part audit codes in AuditResults::WORKFLOW_REPORT_CODES Nov 5, 2022
@jmartin-sul
Copy link
Member Author

The easiest way to test this is probably to just deploy the potential fix to QA or stage, and in rails console there, run: PreservedObject.find_each(&:audit_moab_version_replication!).

that'll kick off replication for all objects. you may want to double-check, but as of a few days ago, each had about 39k druids, which is not a terribly huge amount of objects on which to run replication audit. those environments are a bit of a mess, so the only downside is that those envs are a mess, so a lot of errors will probably be reported.

actually, now that i think about it, we might want to wait for #1986 to be finished before doing this.

ok, marking blocked.

@jmartin-sul jmartin-sul changed the title figure out how to re-enable zip part audit codes in AuditResults::WORKFLOW_REPORT_CODES [BLOCKED by #1986] figure out how to re-enable zip part audit codes in AuditResults::WORKFLOW_REPORT_CODES Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant