This repository has been archived by the owner on May 28, 2024. It is now read-only.
[HOLD - doing report first] Update sw_subject_geographic_ssim to use stanford-mods.subjects.geographic_facet #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubjects.geographic_facet
mjgiarlo
reviewed
Sep 28, 2023
| @@ -24,7 +24,7 @@ def to_solr | |||
| 'contributor_orcids_ssim' => orcids, | |||
| 'sw_display_title_tesim' => title, | |||
| 'sw_subject_temporal_ssim' => subject_temporal, | |||
| 'sw_subject_geographic_ssim' => subject_geographic, | |||
| 'sw_subject_geographic_ssim' => stanford_mods_record.geographic_facet.uniq, | |||
There was a problem hiding this comment.
It looks like all the test changes below are negative tests now. What does the change now map to?
7 tasks
ndushay
changed the title
|
Specs make it look like "it's opposite day!" -- this seems to show significant logic differences between straight cocina indexing and stanford-mods indexing. |
ndushay
suggested changes
Oct 3, 2023
|
ACTION ITEM per discussion with @andrewjbtw @ndushay and @aaron-collier on 10/3/23: Aaron will write "report" tickets for sussing out the differences between stanford mods indexing and dor-indexing-app for this part of descriptive metadata. |
ndushay
changed the title
ndushay
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOLD - see sul-dlss/dor-services-app#4611 which is a report to compare values coming from cocina with values coming from stanford-mods ... so we can see whether we should do this or not.
Why was this change made? 🤔
Part of #992
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, run integration tests that exercise indexing (e.g. searches in Argo for newly created/updated items, access_indexing_spec) and/or test in [stage|qa] environment, in addition to specs. ⚡