Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): [components] add WIconButton #308

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

vitorsaa2k
Copy link
Contributor

part of #272

i didnt know what to do with the big/small prop so i just made it intercalate between two classes, which one of them makes the button bigger

-small button
image
-big button
image

Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big is for size 40x40, small is for 24x24

Please use SImage instead.

See the menu component's story for async asset loaders. Load all assets, pass result of getAsset('image.icon.build') to the story renderer.

@vitorsaa2k
Copy link
Contributor Author

big is for size 40x40, small is for 24x24

Please use SImage instead.

See the menu component's story for async asset loaders. Load all assets, pass result of getAsset('image.icon.build') to the story renderer.

i've tried this but the button is blank on the story
image
image

@meganindya
Copy link
Member

The SVG has no fill color or is #fff. It is by design so the fill can be set using CSS. I need this component. I can finish this.

@meganindya meganindya merged commit 75b2391 into sugarlabs:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants