new makenode for sudowrt v0.3.0 (dispossessed) #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to replace the
makenode.js
node script with a shell script,makenode.sh
, based on the work done in sudomesh/sudowrt-firmware#132 (dispossessed). It is essentially /opt/mesh/retrieve_ip rewritten to run on your local machine instead on the home node (i.e. usejq
instead ofjshn
).Pros: Fewer dependencies (curl and jq) that are easier to install.
Cons: Currently, does not send any info back to meshnode databse and only works with latest firmware build (http://builds.sudomesh.org/builds/sudowrt/dispossessed/0.3.0/) which still in unstable/testing. Could be adapted to work with v0.2.x, but that seems unnecessary and would just put us back into the situation of maintaining OpenWrt configs in two separate repos.
Suggestion: Any further configuration options (i.e. hostname, private SSID, passwords) should be added directly to /opt/mesh/autoconf NOT to makenode.sh, since any improvements made to autoconf could be utilized by makenode or peoplesopen-dash