[FEATURE] Update extension for TYPO3 v12 support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calien666
force-pushed
the
prepare-v12
branch
14 times, most recently
from
d72375a
to
dca1f9d
Compare
The update adds a new controller, DataSheetImportController, for handling data import from excel sheets. This includes supporting files, templates and necessary configurations. Also, there are enhancements to user access check functions with better considerations for user permissions. A testing framework is also being introduced though actual tests are not yet added. This is preparation work for updating this extension for v12/v13 support
calien666
force-pushed
the
prepare-v12
branch
from
dca1f9d
to
90853a9
Compare
calien666
changed the title
calien666
force-pushed
the
prepare-v12
branch
3 times, most recently
from
9d16021
to
3757aee
Compare
sbuerk
suggested changes
Jan 14, 2024
| } | ||
|
|
||
| /** @deprecated Function call will be removed in 6.0 */ | ||
| $insertData = $this->callHook($insertData, $importJob->getTable()); |
There was a problem hiding this comment.
See comment in the callHook() method. I would suggest to consider dropping the hook directly.
sbuerk
suggested changes
Jan 14, 2024
sbuerk
suggested changes
Jan 14, 2024
|
Successfully tested the following functions in a running v12.4.9 instance:
|
This was referenced Feb 8, 2024
This was referenced Feb 8, 2024
calien666
force-pushed
the
prepare-v12
branch
2 times, most recently
from
63c1718
to
7a68480
Compare
With this PR the extension is shippable for TYPO3 v12. This adds support for the backend integration.
calien666
force-pushed
the
prepare-v12
branch
from
7a68480
to
9674576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the extension is shippable for TYPO3 v12. This adds support
for the backend integration.
This PR is ready for testing