feat: global memory sharding #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtguibas
reviewed
Jul 1, 2024
core/src/operations/lt.rs
Outdated
|
|
||
| let a: [AB::Expr; N] = core::array::from_fn(|i| a[i].clone().into()); | ||
| let b: [AB::Expr; N] = core::array::from_fn(|i| b[i].clone().into()); | ||
| // a.clone().try_into().unwrap(); |
jtguibas
reviewed
Jul 1, 2024
| // The byte flags give a specification of which byte is `first_eq`, i,e, the first most | ||
| // significant byte for which the element `a` is smaller than `b`. To verify the | ||
| // less-than claim we need to check that: | ||
| // * For all bytes until `first_eq` the element `a` byte is equal to the `b` byte. |
jtguibas
reviewed
Jul 1, 2024
| @@ -101,6 +111,22 @@ impl SP1Prover { | |||
| "non-last shard is halted", | |||
| )); | |||
| } | |||
| // The previous last initialized address of the previous shard should be equal to | |||
| // the last initialized address of the current shard. | |||
There was a problem hiding this comment.
I think you mean previous init, not last initialized for second part
There was a problem hiding this comment.
(code is correct, just not comment)
jtguibas
reviewed
Jul 1, 2024
| )); | ||
| } | ||
| // The previous last finalized address of the previous shard should be equal to | ||
| // the last finalized address of the current shard. |
jtguibas
approved these changes
Jul 1, 2024
|
Before you merge, let's coordinate on merging it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.