Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update verifier contract templates #963

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

mattstam
Copy link
Member

ouputs:

  • sol 0.8.20
  • better error handling for version mismatch
  • changes interfaces so ISP1Verifier is just the verifyProof

@mattstam mattstam force-pushed the mattstam/contract-changes branch from ee49bf3 to 47278e4 Compare June 20, 2024 20:06
@mattstam mattstam changed the title feat: update verifier contracts feat: update verifier contract templates Jun 20, 2024
if (proofBytesPrefix != bytes4(VKEY_HASH())) {
revert WrongVersionProof();
) external view {
bytes4 recievedSelector = bytes4(proofBytes[:4]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: received

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mattstam mattstam merged commit d3b4617 into dev Jun 20, 2024
4 of 6 checks passed
@mattstam mattstam deleted the mattstam/contract-changes branch June 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants