feat: byte multiplicity channel #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevjue
reviewed
May 23, 2024
core/src/alu/lt/mod.rs
Outdated
| @@ -116,6 +119,8 @@ impl<F: PrimeField32> MachineAir<F> for LtChip { | |||
| let c = event.c.to_le_bytes(); | |||
|
|
|||
| cols.shard = F::from_canonical_u32(event.shard); | |||
| cols.channel = F::from_canonical_u32(event.channel); | |||
| cols.channel = F::from_canonical_u32(event.channel); | |||
kevjue
reviewed
May 23, 2024
core/src/alu/mul/mod.rs
Outdated
Comment on lines
241
to
242
| cols.channel = F::from_canonical_u32(event.channel); | ||
| cols.channel = F::from_canonical_u32(event.channel); |
There was a problem hiding this comment.
Suggested change
| cols.channel = F::from_canonical_u32(event.channel); | |
| cols.channel = F::from_canonical_u32(event.channel); | |
| cols.channel = F::from_canonical_u32(event.channel); |
kevjue
approved these changes
May 23, 2024
core/src/cpu/columns/channel.rs
Outdated
| // Accumulate the reconstructed channel. | ||
| reconstruct_channel += selector.into() * AB::Expr::from_canonical_u32(i as u32); | ||
| } | ||
| // Asser that the reconstructed channel is the same as the channel. |
core/src/runtime/mod.rs
Outdated
Comment on lines
867
to
868
| self.state.channel += 1; | ||
| self.state.channel %= NUM_BYTE_LOOKUP_CHANNELS; |
There was a problem hiding this comment.
nit: Maybe collapse the two lines into one.
Suggested change
| self.state.channel += 1; | |
| self.state.channel %= NUM_BYTE_LOOKUP_CHANNELS; | |
| self.state.channel = (self.state.channel + 1) % NUM_BYTE_LOOKUP_CHANNELS; |
core/src/runtime/state.rs
Outdated
| @@ -25,6 +25,9 @@ pub struct ExecutionState { | |||
| /// executed in this shard. | |||
| pub clk: u32, | |||
|
|
|||
| /// The channel alternates between 0 and 1, used to controll byte lookup multiplicity. | |||
There was a problem hiding this comment.
nit: Consider updating the column for NUM_BYTE_LOOKUP_CHANNELS.
| @@ -23,6 +23,9 @@ use crate::bytes::trace::NUM_ROWS; | |||
| /// The number of different byte operations. | |||
| pub const NUM_BYTE_OPS: usize = 9; | |||
|
|
|||
| /// The number of different byte lookup channels. | |||
| pub const NUM_BYTE_LOOKUP_CHANNELS: u32 = 4; | |||
There was a problem hiding this comment.
nit: Should this be changed to 4 to minimize the increase in columns on the CPU table (via the channel selector columns)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.