Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plonk prover #795

Merged
merged 20 commits into from
May 23, 2024
Merged

feat: plonk prover #795

merged 20 commits into from
May 23, 2024

Conversation

jtguibas
Copy link
Contributor

No description provided.

@jtguibas jtguibas changed the base branch from main to dev May 23, 2024 03:01
@jtguibas jtguibas marked this pull request as ready for review May 23, 2024 10:16
ratankaliani
ratankaliani reviewed May 23, 2024
View reviewed changes
book/SUMMARY.md Show resolved Hide resolved
book/developers/building-groth16-artifacts.md Outdated Show resolved Hide resolved
book/verifying-proofs/solidity-and-evm.md Outdated Show resolved Hide resolved
prover/Makefile Outdated Show resolved Hide resolved
prover/Makefile Outdated Show resolved Hide resolved
prover/src/install.rs Outdated Show resolved Hide resolved
recursion/compiler/src/constraints/mod.rs Outdated Show resolved Hide resolved
ratankaliani
ratankaliani approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small nits & add a PR description and we should be good to go. Probably good that you add a note about how this is a breaking change for the SDK.

@jtguibas jtguibas enabled auto-merge May 23, 2024 22:33
@jtguibas jtguibas added this pull request to the merge queue May 23, 2024
Merged via the queue into dev with commit d7e1851 May 23, 2024
5 checks passed
@jtguibas jtguibas deleted the john/plonk-prover branch May 23, 2024 23:20
erabinov pushed a commit that referenced this pull request May 24, 2024
@jtguibas @ctian1 @erabinov
feat: plonk prover (#795)
1429c28 
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Chris Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani ratankaliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtguibas @ratankaliani @ctian1