feat: create bn254 scalar field chip #1902
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S1nus
changed the title
|
bn254 fr is grumpkin fp. this pr is useful for you https://github.com/scroll-tech/sp1/pull/17/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to compute this function in SP1, poseidon hash over bn254 scalar, as it would be computed in a Halo2 circuit. This is for a DA integration with a zkrollup built with Halo2 KZG.
Solution
It appears the bn254 precompiles in SP1 are for the base field, which makes sense to help verify proofs and compute pairings. However, iiuc this is not sufficient to perform computations as a halo2 circuit would, since the circuit inputs are elements of the scalar field.
Here I am developing a bn254 scalar field precompile, I expect it to be the same as Fp precompile but with a different modulus.
PR Checklist