Skip to content

Commit

Permalink
remove some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tqn committed Aug 12, 2024
1 parent 8fab0e4 commit 93cc604
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions recursion/circuit-v2/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ pub trait BabyBearFriConfig:
fn fri_config(&self) -> &FriConfig<FriMmcs<Self>>;
}

// TODO write subtrait that enables use of the Variable variants
// consider merging this into the above trait
pub trait BabyBearFriConfigVariable: BabyBearFriConfig {
// Is this is the best place to put this?
type C: Config<F = Self::Val, EF = Self::Challenge>;
Expand All @@ -126,7 +124,6 @@ pub trait BabyBearFriConfigVariable: BabyBearFriConfig {

impl BabyBearFriConfig for BabyBearPoseidon2 {
type ValMmcs = sp1_core::utils::baby_bear_poseidon2::ValMmcs;
// type RowMajorProverData = PcsProverData<Self>;
type FriChallenger = <Self as StarkGenericConfig>::Challenger;

fn fri_config(&self) -> &FriConfig<FriMmcs<Self>> {
Expand All @@ -142,7 +139,6 @@ impl BabyBearFriConfigVariable for BabyBearPoseidon2 {

impl BabyBearFriConfig for BabyBearPoseidon2Outer {
type ValMmcs = OuterValMmcs;
// type RowMajorProverData = PcsProverData<Self>;
type FriChallenger = <Self as StarkGenericConfig>::Challenger;

fn fri_config(&self) -> &FriConfig<FriMmcs<Self>> {
Expand Down

0 comments on commit 93cc604

Please sign in to comment.