New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong salt used #2

Open

pvgo80 wants to merge 1 commit into main from fix-used-wrong-salt

Collaborator

pvgo80 commented Oct 9, 2024

Incredibly, I missed the previous refactoring in THREE places, the right amount to make the testDeterministicUUPS pass with the wrong logic.


          fix: wrong salt used

403c42d

pvgo80 requested a review from naps62

October 9, 2024 07:05

Member

naps62 commented Oct 9, 2024

Ahah. I too was busy with a "two bugs canceling each other out" yesterday, so I can simpathizr

naps62 approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet