Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a default transition_changeset/4 #20

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

zamith
Copy link
Member

@zamith zamith commented Sep 1, 2023

Why:

This change addresses the need by:

  • Adding a default implementation of transition_changeset/4 that we had
    removed

Why:

* Fixes #17

This change addresses the need by:

* Adding a default implementation of transition_changeset/4 that we had
  removed
@naps62 naps62 merged commit 31b215f into master Sep 8, 2023
3 checks passed
@naps62 naps62 deleted the fix-transition-changeset-support branch September 8, 2023 08:46
@linusdm
Copy link

linusdm commented Sep 8, 2023

Yes, this does the job! Thank you!

@linusdm
Copy link

linusdm commented Oct 9, 2023

Just a very kind reminder for thinking about releasing a new version with this fix :) new users of the lib might be turned off when this fallback behaviour doesn't work as documented. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation for transition_changeset/4 required for all transitions since 0.5.0?
3 participants