Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image loading & fix kiwill error #200

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update Image loading & fix kiwill error #200

merged 2 commits into from
Apr 11, 2024

Conversation

luistorres
Copy link
Member

Why:

  • We want to load images the best way possible, and currently bg loading is not optimized

This change addresses the need by:

  • Using local loading of main assets, adjusting local imports for 'png' files, and native jsx for svgs.

Extra:

  • Fix kiwill signer issues breaking main because of idos update

@luistorres luistorres self-assigned this Apr 11, 2024
@luistorres luistorres requested a review from DavideSilva April 11, 2024 11:49
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for ctznd ready!

Name Link
🔨 Latest commit b9bc162
🔍 Latest deploy log https://app.netlify.com/sites/ctznd/deploys/6617eb4cb958ac0008291fa6
😎 Deploy Preview https://deploy-preview-200--ctznd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

luistorres and others added 2 commits April 11, 2024 14:52
Why:

We want to load images the best way possible, and currently bg loading is not optimized
This change addresses the need by:

Using local loading of main assets, adjusting local imports for 'png' files, and native jsx for svgs.
Extra:

Fix kiwill signer issues breaking main because of idos update
- Reads projects data from server
- Updated sales endpoint to fit into next server-actions format (only
simple objects allowed as reply)
- Add error boundary screen
@luistorres luistorres merged commit b9bc162 into main Apr 11, 2024
@luistorres luistorres deleted the lt/imageLoading branch April 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants