Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node and Hardhat #174

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Update Node and Hardhat #174

merged 5 commits into from
Feb 27, 2024

Conversation

DavideSilva
Copy link
Member

@DavideSilva DavideSilva commented Feb 27, 2024

Why:

  • Some package updates and a bit of maintenance was needed

How:

  • Changing the node version in tool-versions to 20.11.1
  • Changing the hardhat version in package.json to 2.20.1
  • Adding the hardhat-foundry dev package so we can start migrating out
    of Hardhat in favor of Foundry
  • Updating the CI node version
  • Removing the reviewpad action
  • Adding Foundry to the contracts-test workflow

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discovery-dao ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 0:13am

Why:
* Some package updates were needed

How:
* Changing the node version in `tool-versions` to `20.11.1`
* Changing the `hardhat` version in `package.json` to `2.20.1`
* Adding the `hardhat-foundry` dev package so we can start migrating out
  of Hardhat in favor of Foundry
Copy link
Member

@luistorres luistorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I can't add much about the contracts workflows 😅

@DavideSilva DavideSilva merged commit 9393505 into main Feb 27, 2024
5 checks passed
@DavideSilva DavideSilva deleted the ds/update-node branch February 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants