Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Commit

Permalink
remove no longer needed context
Browse files Browse the repository at this point in the history
  • Loading branch information
samos123 committed Sep 6, 2023
1 parent baeb88c commit 1b7bd68
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions internal/controller/notebook_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ func (r *NotebookReconciler) reconcileNotebook(ctx context.Context, notebook *ap
// return result{}, fmt.Errorf("failed to apply pvc: %w", err)
//}

pod, err := r.notebookPod(ctx, notebook, model, dataset)
pod, err := r.notebookPod(notebook, model, dataset)
if err != nil {
return result{}, fmt.Errorf("failed to construct pod: %w", err)
}
Expand Down Expand Up @@ -314,7 +314,7 @@ func nbPodName(nb *apiv1.Notebook) string {
}

// notebookPod constructs a Pod for the given Notebook.
func (r *NotebookReconciler) notebookPod(ctx context.Context, notebook *apiv1.Notebook, model *apiv1.Model, dataset *apiv1.Dataset) (*corev1.Pod, error) {
func (r *NotebookReconciler) notebookPod(notebook *apiv1.Notebook, model *apiv1.Model, dataset *apiv1.Dataset) (*corev1.Pod, error) {
const containerName = "notebook"

envVars, err := resolveEnv(notebook.Spec.Env)
Expand Down
4 changes: 2 additions & 2 deletions internal/controller/server_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (r *ServerReconciler) findServersForModel(ctx context.Context, obj client.O
return reqs
}

func (r *ServerReconciler) serverDeployment(ctx context.Context, server *apiv1.Server, model *apiv1.Model) (*appsv1.Deployment, error) {
func (r *ServerReconciler) serverDeployment(server *apiv1.Server, model *apiv1.Model) (*appsv1.Deployment, error) {
replicas := int32(1)

envVars, err := resolveEnv(server.Spec.Env)
Expand Down Expand Up @@ -266,7 +266,7 @@ func (r *ServerReconciler) reconcileServer(ctx context.Context, server *apiv1.Se
return result{}, fmt.Errorf("failed to apply service: %w", err)
}

deploy, err := r.serverDeployment(ctx, server, &model)
deploy, err := r.serverDeployment(server, &model)
if err != nil {
return result{}, fmt.Errorf("failed to construct deployment: %w", err)
}
Expand Down

0 comments on commit 1b7bd68

Please sign in to comment.