build: add flag to treat warnings as errors and enable in CI #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpienaar
approved these changes
Jan 17, 2025
|
I think this will pass once #64 will be merged. |
ingomueller-net
force-pushed
the
warning-as-error
branch
2 times, most recently
from
6371bcf to
6678ca5
Compare
This PR adds an option to our CMake files that allow treating compiler warnings as errors in the targets from this repository and enables that option in CI. This will enforce that we fix compiler warnings before merging PRs, which should help to keep our code clean. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
warning-as-error
branch
from
6678ca5 to
7b502e8
Compare
Signed-off-by: Ingo Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and, therefor, includes #66.
This PR adds an option to our CMake files that allow treating compiler warnings as errors in the targets from this repository and enables that option in CI. This will enforce that we fix compiler warnings before merging PRs, which should help to keep our code clean.