feat: implement AdvancedExtension and at it to Plan
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
advanced-extension
branch
from
2e9b7aa to
f892761
Compare
ingomueller-net
force-pushed
the
advanced-extension
branch
from
f892761 to
6f18ff1
Compare
jpienaar
approved these changes
Jan 17, 2025
This PR implements the `AdvanceExtension` message type as a custom attribute with two `StringAttr`s as well as an `AnyType` with a parameter for the type URL to represent the `Any` messages as typed `StringAttr`s. The PR also adds those attributes to the `PlanOp` in order to represent the `advanced_extensions` message of the `Plan` message. We do not currently need this attribute but it is one of the few missing fields of the `Plan` message as well as many other messages we have otherwise implemented, so it allows us to get to higher coverage with relatively little effort. Signed-off-by: Ingo Müller <[email protected]>
Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
advanced-extension
branch
from
6f18ff1 to
31fab9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
AdvanceExtensionmessage type as a custom attribute with twoStringAttrs as well as anAnyTypewith a parameter for the type URL to represent theAnymessages as typedStringAttrs. The PR also adds those attributes to thePlanOpin order to represent theadvanced_extensionsmessage of thePlanmessage.We do not currently need this attribute but it is one of the few missing fields of the
Planmessage as well as many other messages we have otherwise implemented, so it allows us to get to higher coverage with relatively little effort.