Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce uuid types #49

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

dshaaban01
Copy link
Contributor

@dshaaban01 dshaaban01 commented Jan 1, 2025

Implements uuid type and attribute types. Tests again added for types but not for attribute types - waiting on this PR to be merged and then will add those tests to project.mlir test file (similarly to integer, float, string types)!

This is a stacked PR, please only review latest commit (21197c0)

@ingomueller-net

This is a 16-byte binary value.
}];
let parameters = (ins ArrayRefParameter<"uint8_t", "">:$value);
let assemblyFormat = [{ `<` $value `>` }];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a verifier/contraint to ensure it's exactly 16 bytes?

This is a 16-byte binary value.
}];
let parameters = (ins ArrayRefParameter<"uint8_t", "">:$value);
let assemblyFormat = [{ `<` $value `>` }];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to (eventually) print the UUIDs in the typical format (see Wikipedia). Doesn't need to be now; can just be a TODO.

If you do want to go for it, the APInt class from LLVM probably has a few interesting features:

@dshaaban01
Copy link
Contributor Author

I don't know why Build and Test is failing...? Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants