-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce uuid
types
#49
base: main
Are you sure you want to change the base?
Conversation
a2e79e7
to
21197c0
Compare
a81a7a6
to
de676ee
Compare
This is a 16-byte binary value. | ||
}]; | ||
let parameters = (ins ArrayRefParameter<"uint8_t", "">:$value); | ||
let assemblyFormat = [{ `<` $value `>` }]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a verifier/contraint to ensure it's exactly 16 bytes?
This is a 16-byte binary value. | ||
}]; | ||
let parameters = (ins ArrayRefParameter<"uint8_t", "">:$value); | ||
let assemblyFormat = [{ `<` $value `>` }]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to (eventually) print the UUIDs in the typical format (see Wikipedia). Doesn't need to be now; can just be a TODO.
If you do want to go for it, the APInt
class from LLVM probably has a few interesting features:
- Construct from array: constructor
- Extract bits at certain positions:
extractBits
. - Convert to hex string:
toString
withradix
set to 16.
de676ee
to
29cd1b6
Compare
I don't know why Build and Test is failing...? Any ideas? |
Implements
uuid
type and attribute types. Tests again added for types but not for attribute types - waiting on this PR to be merged and then will add those tests to project.mlir test file (similarly to integer, float, string types)!This is a stacked PR, please only review latest commit (21197c0)
@ingomueller-net