feat: introduce time type
#47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
approved these changes
Jan 9, 2025
dshaaban01
force-pushed
the
dalia/types/time
branch
from
09e06f7 to
f4da961
Compare
dshaaban01
force-pushed
the
dalia/types/time
branch
from
f4da961 to
41014ff
Compare
dshaaban01
force-pushed
the
dalia/types/time
branch
from
c28fd42 to
8788328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
timetype and attribute types. Tests again added for types but not for attribute types - waiting on this PR to be merged and then will add those tests to project.mlir test file (similarly to integer, float, string, binary, date etc. types)!This is a stacked PR, please only review latest commit (09e06f7)