feat: introduce date type
#46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshaaban01
force-pushed
the
dalia/types/date
branch
2 times, most recently
from
86688a3 to
4f24fa3
Compare
ingomueller-net
approved these changes
Jan 9, 2025
test/Dialect/Substrait/types.mlir
Outdated
| %0 = named_table @t1 as ["a"] : tuple<!substrait.date> | ||
| yield %0 : tuple<!substrait.date> | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: final line break.
Consider configuring VS Code to add those line breaks automatically.
There was a problem hiding this comment.
Haha thank you! This indeed is the smarter approach.
dshaaban01
force-pushed
the
dalia/types/date
branch
from
71c644a to
63167ef
Compare
dshaaban01
force-pushed
the
dalia/types/date
branch
from
63167ef to
ea450f9
Compare
dshaaban01
force-pushed
the
dalia/types/date
branch
from
6cca2f1 to
122a2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
datetype and attribute types. Tests again added for types but not for attribute types - waiting on this PR to be merged and then will add those tests to project.mlir test file (similarly to integer, float, string, binary etc. types)!This is a stacked PR, please only review latest commit (4f24fa3)