Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds #17

Merged
merged 4 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,30 @@ jobs:
strategy:
matrix:
ruby:
- '3.0.5'
- '3.1.3'
- '3.2.0'
- '3.0'
- '3.1'
- '3.2'

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run the default task
run: bundle exec rake
- name: Tests
run: bundle exec rake test

lint:
runs-on: ubuntu-latest
name: Lint

steps:
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true
ruby-version: '3.2'
- name: StandardRB
run: bundle exec rake standard
6 changes: 3 additions & 3 deletions test/input_group/test_checkbox_field.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Felt::InputGroup::CheckboxFieldTest < ViewComponent::TestCase
include Felt::InputGroup::CommonBehavior

def test_defaults_the_value_to_1
@model.send("#{@attribute}=", "Something entirely different")
@model.send(:"#{@attribute}=", "Something entirely different")

render_component_to_html

Expand All @@ -54,7 +54,7 @@ def test_accepts_a_specific_unchecked_value
end

def test_checks_the_checkbox_if_value_is_truthy
@model.send("#{@attribute}=", true)
@model.send(:"#{@attribute}=", true)

render_component_to_html

Expand All @@ -63,7 +63,7 @@ def test_checks_the_checkbox_if_value_is_truthy
end

def test_unchecks_the_checkbox_if_value_is_falsey
@model.send("#{@attribute}=", false)
@model.send(:"#{@attribute}=", false)

render_component_to_html

Expand Down
2 changes: 1 addition & 1 deletion test/input_group/test_email_field.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_uses_configured_classes_for_wrapping_element
end

def test_uses_the_value_from_the_object
@model.send("#{@attribute}=", "Something entirely different")
@model.send(:"#{@attribute}=", "Something entirely different")

render_component_to_html

Expand Down
2 changes: 1 addition & 1 deletion test/input_group/test_text_field.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Felt::InputGroup::TextFieldTest < ViewComponent::TestCase
include Felt::InputGroup::CommonBehavior

def test_uses_the_value_from_the_object
@model.send("#{@attribute}=", "Something entirely different")
@model.send(:"#{@attribute}=", "Something entirely different")

render_component_to_html

Expand Down