enable ts strict in common package #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwiname
reviewed
Jun 16, 2024
| @@ -10,7 +10,7 @@ import {DEFAULT_MANIFEST} from '../utils'; | |||
|
|
|||
| export class GithubReader implements Reader { | |||
| private readonly api: AxiosInstance; | |||
| private defaultBranch: string; | |||
| private defaultBranch!: string; | |||
There was a problem hiding this comment.
I think this can be optional
Comment on lines
+11
to
+16
| specVersion!: string; | ||
| @IsString({each: true}) | ||
| projects: string[]; | ||
| projects!: string[]; | ||
| @IsObject() | ||
| @Type(() => RunnerQueryBaseModel) | ||
| query: QuerySpec; | ||
| query!: QuerySpec; |
There was a problem hiding this comment.
Can you please explain this, it doesn't make sense to me to need the !. Same applies to the other files with this change
There was a problem hiding this comment.
How should this be modified? The code only declares a class but doesn’t use it anywhere. Should I define a constructor for it?
There was a problem hiding this comment.
This is used by class-transformer/class-validator so it will construct this class and validate it. It might be worth looking at their repos to see how others have solved this
|
|
||
| get root(): string { | ||
| return path.resolve(this.projectPath); | ||
| } | ||
|
|
||
| async getPkg(): Promise<IPackageJson | undefined> { | ||
| return yaml.load(await this.getFile('package.json')) as IPackageJson; | ||
| const pkg = (await this.getFile('package.json')) || ''; | ||
| assert(pkg, 'package.json not found'); |
There was a problem hiding this comment.
I think rather than assert here, we could update getFile to no longer return undefined and instead throw an error
There was a problem hiding this comment.
getProjectSchema(): Promise<unknown | undefined>;
getPkg(): Promise<IPackageJson | undefined>;
getFile(file: string): Promise<string | undefined>;
Should I modify Reader? Not returning undefined.
stwiname
reviewed
Jun 18, 2024
| try { | ||
| const branch = await this.getDefaultBranch(); | ||
| const {data} = await this.api.get(path.join(branch, fileName)); | ||
| return data; | ||
| } catch (err) { | ||
| return undefined; | ||
| throw new Error('Fetch project from github got undefined'); |
There was a problem hiding this comment.
Suggested change
| throw new Error('Fetch project from github got undefined'); | |
| throw new Error('Failed to fetch file from github', { cause: err }); |
| return Promise.resolve(undefined); | ||
| // eslint-disable-next-line @typescript-eslint/require-await | ||
| async getPkg(): Promise<IPackageJson> { | ||
| throw new Error('Project package.json is not found'); |
There was a problem hiding this comment.
This is a change in behaviour, we need to check that nowhere calls this
Suggested change
| throw new Error('Project package.json is not found'); | |
| throw new Error('IPFS Reader doesn't support reading package.json'); |
| console.error(`Failed to fetch file from IPFS: ${fileName}`, e); | ||
| return undefined; | ||
| console.error(`Failed to fetch project from IPFS: ${fileName}`, e); | ||
| throw new Error(`Failed to fetch project from IPFS: ${fileName}`); |
There was a problem hiding this comment.
We have started providing the cause to all errors where we can. It would be worth reading this https://medium.com/with-orus/the-5-commandments-of-clean-error-handling-in-typescript-93a9cbdf1af5
Suggested change
| throw new Error(`Failed to fetch project from IPFS: ${fileName}`); | |
| throw new Error(`Failed to fetch project from IPFS: ${fileName}`, { cause: e }); |
| @@ -1,6 +1,7 @@ | |||
| // Copyright 2020-2024 SubQuery Pte Ltd authors & contributors | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
|
|
|||
| import assert from 'assert'; | |||
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 65.23% (-4.87% 🔻) |
18768/28771 |
| 🟡 | Branches | 78.93% (+0.64% 🔼) |
2409/3052 |
| 🟡 | Functions | 66.35% (+3.85% 🔼) |
1039/1566 |
| 🟡 | Lines | 65.23% (-4.87% 🔻) |
18768/28771 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / migrate.ts |
85.09% | 18.18% | 100% | 85.09% |
| 🟢 | ... / migrate-abis.controller.ts |
95% | 87.5% | 100% | 95% |
| 🟢 | ... / constants.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / ethereum.ts |
82.05% | 83.33% | 100% | 82.05% |
| 🟢 | ... / migrate-manifest.controller.ts |
88% | 73.33% | 88.89% | 88% |
| 🟢 | ... / migrate-mapping.controller.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / migrate-controller.ts |
92.31% | 84.62% | 100% | 92.31% |
| 🟢 | ... / migrate.fixtures.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / migrate-schema.controller.ts |
100% | 100% | 100% | 100% |
| 🔴 | ... / types.ts |
0% | 0% | 0% | 0% |
| 🟢 | ... / createProject.fixtures.ts |
96.88% | 80% | 100% | 96.88% |
| 🟢 | ... / networkFamily.ts |
92.59% | 88.89% | 100% | 92.59% |
| 🟢 | ... / admin.controller.ts |
98.62% | 96.55% | 92.86% | 98.62% |
| 🟢 | ... / blockRange.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / dictionary.fixtures.ts |
100% | 100% | 100% | 100% |
| 🟡 | ... / monitor.service.ts |
69.61% | 86.9% | 94.12% | 69.61% |
| 🔴 | ... / sandbox.service.ts |
33.33% | 50% | 25% | 33.33% |
| 🔴 | ... / worker.monitor.service.ts |
41.46% | 100% | 0% | 41.46% |
| 🔴 | ... / process.ts |
50% | 66.67% | 40% | 50% |
| 🔴 | ... / foreceClean.init.ts |
47.62% | 100% | 0% | 47.62% |
| 🔴 | ... / reindex.init.ts |
34.48% | 100% | 0% | 34.48% |
| 🟢 | ... / string.ts |
100% | 100% | 100% | 100% |
| 🔴 | ... / admin.module.ts |
0% | 0% | 0% | 0% |
| 🔴 | ... / datasourceProcessors.ts |
0% | 0% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / deploy.ts |
18.91% (-2.24% 🔻) |
100% | 50% (+50% 🔼) |
18.91% (-2.24% 🔻) |
| 🔴 | ... / publish.ts |
44% (-45.33% 🔻) |
40% (-17.14% 🔻) |
100% | 44% (-45.33% 🔻) |
| 🔴 | ... / deploy-controller.ts |
32.49% (-4.98% 🔻) |
100% (+22.22% 🔼) |
12.5% (-12.5% 🔻) |
32.49% (-4.98% 🔻) |
| 🟢 | ... / generate-controller.ts |
97.65% | 93.85% (-0.18% 🔻) |
100% | 97.65% |
| 🟡 | ... / init-controller.ts |
76.73% (+6.24% 🔼) |
67.65% (-0.35% 🔻) |
61.11% (+7.78% 🔼) |
76.73% (+6.24% 🔼) |
| 🔴 | ... / project-controller.ts |
17.81% (-79.45% 🔻) |
100% (+40% 🔼) |
0% (-100% 🔻) |
17.81% (-79.45% 🔻) |
| 🔴 | ... / publish-controller.ts |
59.34% (-20.91% 🔻) |
58.62% (-12.49% 🔻) |
60% (-40% 🔻) |
59.34% (-20.91% 🔻) |
| 🔴 | ... / models.ts |
53.33% (-46.11% 🔻) |
94.44% (+2.14% 🔼) |
38.46% (-61.54% 🔻) |
53.33% (-46.11% 🔻) |
| 🟢 | ... / model.ts |
93.14% (-4.57% 🔻) |
100% | 73.33% (+1.9% 🔼) |
93.14% (-4.57% 🔻) |
| 🔴 | ... / models.ts |
47.06% (-52.94% 🔻) |
100% | 0% (-100% 🔻) |
47.06% (-52.94% 🔻) |
| 🔴 | ... / load.ts |
59.18% | 50% (-5.56% 🔻) |
66.67% | 59.18% |
| 🟡 | ... / github-reader.ts |
65.52% (-23.77% 🔻) |
85.71% (+10.71% 🔼) |
71.43% (-11.9% 🔻) |
65.52% (-23.77% 🔻) |
| 🟡 | ... / ipfs-reader.ts |
62.5% (-23.21% 🔻) |
70% (+6.36% 🔼) |
71.43% (-11.9% 🔻) |
62.5% (-23.21% 🔻) |
| 🟡 | ... / local-reader.ts |
69.77% (-16.28% 🔻) |
100% (+37.5% 🔼) |
83.33% (-16.67% 🔻) |
69.77% (-16.28% 🔻) |
| 🟢 | ... / reader.ts |
81.58% (-7.89% 🔻) |
50% (-25% 🔻) |
100% | 81.58% (-7.89% 🔻) |
| 🔴 | ... / utils.ts |
54.21% (-8.5% 🔻) |
73.33% (+0.16% 🔼) |
52% (-4% 🔻) |
54.21% (-8.5% 🔻) |
| 🔴 | ... / base.ts |
40.4% (-57.6% 🔻) |
87.5% (-12.5% 🔻) |
40% (-40% 🔻) |
40.4% (-57.6% 🔻) |
| 🔴 | ... / models.ts |
25.32% (-74.68% 🔻) |
100% | 0% (-100% 🔻) |
25.32% (-74.68% 🔻) |
| 🟢 | ... / NodeConfig.ts |
88.48% (-0.12% 🔻) |
77.59% (-2.04% 🔻) |
86.96% (+0.91% 🔼) |
88.48% (-0.12% 🔻) |
| 🟡 | ... / ProjectUpgrade.service.ts |
73.91% (-13.16% 🔻) |
93.67% (+2.31% 🔼) |
84% (-7.3% 🔻) |
73.91% (-13.16% 🔻) |
| 🟢 | ... / db.module.ts |
89.06% (+0.78% 🔼) |
62.5% (-20.83% 🔻) |
80% | 89.06% (+0.78% 🔼) |
| 🟡 | ... / migration-helpers.ts |
75.28% (-0.74% 🔻) |
88.24% (+7.64% 🔼) |
90.91% | 75.28% (-0.74% 🔻) |
| 🟢 | ... / sync-helper.ts |
85.42% (-2.96% 🔻) |
88.04% | 73.77% (-1.23% 🔻) |
85.42% (-2.96% 🔻) |
| 🟡 | ... / StoreOperations.ts |
72.94% (-19.37% 🔻) |
86.36% (+1.36% 🔼) |
87.5% (-12.5% 🔻) |
72.94% (-19.37% 🔻) |
| 🔴 | ... / benchmark.service.ts |
43.36% (-11.89% 🔻) |
66.67% | 36.36% (-3.64% 🔻) |
43.36% (-11.89% 🔻) |
| 🔴 | ... / base-block-dispatcher.ts |
19% (-28.35% 🔻) |
100% | 4.35% (-5.65% 🔻) |
19% (-28.35% 🔻) |
| 🔴 | ... / block-dispatcher.ts |
26.98% (-14.01% 🔻) |
66.67% | 25% (-3.57% 🔻) |
26.98% (-14.01% 🔻) |
| 🔴 | ... / worker-block-dispatcher.ts |
36.17% (-14.04% 🔻) |
100% | 25% (-2.27% 🔻) |
36.17% (-14.04% 🔻) |
| 🔴 | ... / coreDictionary.ts |
45.33% (-54.67% 🔻) |
87.5% (-6.94% 🔻) |
77.78% (-22.22% 🔻) |
45.33% (-54.67% 🔻) |
| 🟡 | ... / dictionary.service.ts |
67% (-18.15% 🔻) |
80% (-5.71% 🔻) |
83.33% (-7.58% 🔻) |
67% (-18.15% 🔻) |
| 🟢 | ... / utils.ts |
92.59% (-3.7% 🔻) |
69.23% (-24.89% 🔻) |
100% | 92.59% (-3.7% 🔻) |
| 🟡 | ... / dictionaryV1.ts |
71.43% (-21.8% 🔻) |
73.81% (-4.45% 🔻) |
91.67% (-8.33% 🔻) |
71.43% (-21.8% 🔻) |
| 🟡 | ... / dictionaryV2.ts |
67.37% (-14.31% 🔻) |
68% (+2.78% 🔼) |
88.89% (-11.11% 🔻) |
67.37% (-14.31% 🔻) |
| 🔴 | ... / ds-processor.service.ts |
33.48% (-28.61% 🔻) |
73.33% (-1.67% 🔻) |
58.33% (-29.17% 🔻) |
33.48% (-28.61% 🔻) |
| 🔴 | ... / dynamic-ds.service.ts |
59.84% (-30.35% 🔻) |
65% (-1.67% 🔻) |
80% (-5.71% 🔻) |
59.84% (-30.35% 🔻) |
| 🟢 | ... / inMemoryCache.service.ts |
86.21% (-13.79% 🔻) |
100% | 75% (-25% 🔻) |
86.21% (-13.79% 🔻) |
| 🔴 | ... / indexer.manager.ts |
16.13% (-17.08% 🔻) |
100% | 10% (-2.5% 🔻) |
16.13% (-17.08% 🔻) |
| 🟢 | ... / PoiBlock.ts |
83.87% (-14.52% 🔻) |
96.55% | 75% (-25% 🔻) |
83.87% (-14.52% 🔻) |
| 🔴 | ... / poi.service.ts |
56.64% (+32.71% 🔼) |
55.56% (-44.44% 🔻) |
80% (+51.43% 🔼) |
56.64% (+32.71% 🔼) |
| 🔴 | ... / poiModel.ts |
40% (-23.64% 🔻) |
71.43% | 44.44% (-12.7% 🔻) |
40% (-23.64% 🔻) |
| 🔴 | ... / poiSync.service.ts |
55.88% (-31% 🔻) |
77.61% (+1.05% 🔼) |
88.89% (-3.42% 🔻) |
55.88% (-31% 🔻) |
| 🟡 | ... / project.service.ts |
65.82% (-14.18% 🔻) |
70.18% | 80.77% (-3.23% 🔻) |
65.82% (-14.18% 🔻) |
| 🟡 | ... / sandbox.ts |
60.49% (-7.49% 🔻) |
57.14% | 57.14% (-4.4% 🔻) |
60.49% (-7.49% 🔻) |
| 🔴 | ... / smartBatch.service.ts |
10.43% (-13.91% 🔻) |
100% | 12.5% (-1.79% 🔻) |
10.43% (-13.91% 🔻) |
| 🟡 | ... / store.service.ts |
64.45% (-1.59% 🔻) |
69.23% (+0.81% 🔼) |
54.84% (-2.3% 🔻) |
64.45% (-1.59% 🔻) |
| 🔴 | ... / entity.ts |
19.23% (-42.31% 🔻) |
100% | 0% | 19.23% (-42.31% 🔻) |
| 🔴 | ... / store.ts |
13.11% (-19.09% 🔻) |
100% | 0% | 13.11% (-19.09% 🔻) |
| 🟡 | ... / cacheModel.ts |
68.89% (-16.18% 🔻) |
85.92% (+7.6% 🔼) |
71.43% (-4.76% 🔻) |
68.89% (-16.18% 🔻) |
| 🟡 | ... / cachePoi.ts |
75.53% (-18.09% 🔻) |
88.89% | 71.43% (-11.9% 🔻) |
75.53% (-18.09% 🔻) |
| 🟢 | ... / cacheable.ts |
89.66% (-0.97% 🔻) |
75% | 100% | 89.66% (-0.97% 🔻) |
| 🟡 | ... / csvStore.service.ts |
76.92% (-14.1% 🔻) |
80% | 80% (-20% 🔻) |
76.92% (-14.1% 🔻) |
| 🟢 | ... / test.runner.ts |
94.9% (-4.43% 🔻) |
77.78% (+4.44% 🔼) |
75% (-25% 🔻) |
94.9% (-4.43% 🔻) |
| 🔴 | ... / testing.service.ts |
12% (-16.57% 🔻) |
100% | 0% | 12% (-16.57% 🔻) |
| 🔴 | ... / worker.builder.ts |
59.83% (-19.36% 🔻) |
65.38% | 80% | 59.83% (-19.36% 🔻) |
| 🔴 | ... / worker.cache.service.ts |
48.78% (-9.76% 🔻) |
100% | 0% | 48.78% (-9.76% 🔻) |
| 🔴 | ... / worker.connectionPoolState.manager.ts |
38.21% (-22.76% 🔻) |
100% | 0% | 38.21% (-22.76% 🔻) |
| 🔴 | ... / worker.dynamic-ds.service.ts |
44.44% (-17.78% 🔻) |
100% | 0% | 44.44% (-17.78% 🔻) |
| 🔴 | ... / worker.service.ts |
20.35% (-24.29% 🔻) |
100% | 0% | 20.35% (-24.29% 🔻) |
| 🟢 | ... / worker.store.service.ts |
80% (-2.61% 🔻) |
100% | 50% | 80% (-2.61% 🔻) |
| 🔴 | ... / worker.ts |
41.82% (-0.63% 🔻) |
100% | 0% | 41.82% (-0.63% 🔻) |
| 🔴 | ... / worker.unfinalizedBlocks.service.ts |
33.33% (-66.67% 🔻) |
100% | 0% (-100% 🔻) |
33.33% (-66.67% 🔻) |
| 🔴 | ... / logger.ts |
44.74% (-19.74% 🔻) |
33.33% | 40% (+20% 🔼) |
44.74% (-19.74% 🔻) |
| 🔴 | ... / event.listener.ts |
43.43% (-37.37% 🔻) |
100% | 23.08% (-1.92% 🔻) |
43.43% (-37.37% 🔻) |
| 🔴 | ... / health.controller.ts |
37.93% (-17.24% 🔻) |
100% | 33.33% (-16.67% 🔻) |
37.93% (-17.24% 🔻) |
| 🔴 | ... / health.service.ts |
26.03% (-31.51% 🔻) |
100% | 16.67% (-3.33% 🔻) |
26.03% (-31.51% 🔻) |
| 🔴 | ... / meta.service.ts |
24.76% (-44.76% 🔻) |
80% | 36.36% (-3.64% 🔻) |
24.76% (-44.76% 🔻) |
| 🔴 | ... / ready.controller.ts |
34.78% (-21.74% 🔻) |
100% | 33.33% (-16.67% 🔻) |
34.78% (-21.74% 🔻) |
| 🔴 | ... / ready.service.ts |
54.17% (-37.5% 🔻) |
100% | 50% (-16.67% 🔻) |
54.17% (-37.5% 🔻) |
| 🔴 | ... / forceClean.service.ts |
22.08% (-4.24% 🔻) |
100% | 0% | 22.08% (-4.24% 🔻) |
| 🔴 | ... / reindex.service.ts |
14.73% (-18.6% 🔻) |
100% | 0% | 14.73% (-18.6% 🔻) |
| 🟡 | ... / autoQueue.ts |
60.3% (-28.09% 🔻) |
85.11% | 73.08% (-6.09% 🔻) |
60.3% (-28.09% 🔻) |
| 🟡 | ... / blocks.ts |
77.78% (-22.22% 🔻) |
88.89% | 66.67% (-33.33% 🔻) |
77.78% (-22.22% 🔻) |
| 🟡 | ... / project.ts |
67.11% (-6.27% 🔻) |
58.49% (-16.09% 🔻) |
77.78% | 67.11% (-6.27% 🔻) |
| 🟢 | ... / promise.ts |
86.44% (-5.32% 🔻) |
100% (+13.64% 🔼) |
71.43% (-14.29% 🔻) |
86.44% (-5.32% 🔻) |
| 🔴 | ... / yargs.ts |
44.38% (-1.11% 🔻) |
100% | 14.29% | 44.38% (-1.11% 🔻) |
| 🟢 | ... / SubqueryProject.ts |
93.33% (-2.19% 🔻) |
46.67% (-35.69% 🔻) |
87.5% (+1.79% 🔼) |
93.33% (-2.19% 🔻) |
| 🟡 | ... / apiPromise.connection.ts |
77.08% (+8% 🔼) |
50% (-30% 🔻) |
62.5% (+19.64% 🔼) |
77.08% (+8% 🔼) |
| 🔴 | ... / worker-block-dispatcher.service.ts |
24.64% (-12.32% 🔻) |
100% | 0% | 24.64% (-12.32% 🔻) |
| 🟢 | ... / substrateDictionary.service.ts |
93.2% (+2.64% 🔼) |
41.67% (-31.06% 🔻) |
100% (+20% 🔼) |
93.2% (+2.64% 🔼) |
| 🟢 | ... / substrateDictionaryV1.ts |
85.05% (-0.43% 🔻) |
70.45% (+0.69% 🔼) |
84.62% (+1.28% 🔼) |
85.05% (-0.43% 🔻) |
| 🟡 | ... / substrateDictionaryV2.ts |
70.79% (-4.72% 🔻) |
50% (-25% 🔻) |
33.33% | 70.79% (-4.72% 🔻) |
| 🟢 | ... / fetch.module.ts |
90% (-1.88% 🔻) |
50% (-25% 🔻) |
100% | 90% (-1.88% 🔻) |
| 🔴 | ... / indexer.manager.ts |
56.35% (-1.2% 🔻) |
100% | 20% (+10.91% 🔼) |
56.35% (-1.2% 🔻) |
| 🟢 | ... / runtimeService.ts |
94.29% (+2.08% 🔼) |
81.82% (-7.07% 🔻) |
100% (+20% 🔼) |
94.29% (+2.08% 🔼) |
| 🔴 | ... / http.ts |
49.03% (-30.89% 🔻) |
40% | 28.57% (-2.2% 🔻) |
49.03% (-30.89% 🔻) |
| 🟢 | ... / project.ts |
88.73% (-0.16% 🔻) |
68.18% | 87.5% | 88.73% (-0.16% 🔻) |
| 🟢 | ... / buffer.ts |
95.12% (-4.88% 🔻) |
95.65% (-4.35% 🔻) |
85.71% (+1.5% 🔼) |
95.12% (-4.88% 🔻) |
| 🟡 | ... / logger.ts |
69.01% (-0.59% 🔻) |
50% (-5% 🔻) |
78.57% (+3.57% 🔼) |
69.01% (-0.59% 🔻) |
Test suite run failed
Failed tests: 7/549. Failed suites: 4/98.
● Codegen can generate schema › Should dedupe enums
ENOENT: no such file or directory, open '/home/runner/work/subql/subql/packages/cli/test/schemaTest/src/types/models/foo.ts'
● ApiPromiseConnection › should not make duplicate requests for state_getRuntimeVersion on httpProvider
thrown: "Exceeded timeout of 5000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
14 | let httpProvider: HttpProvider;
15 |
> 16 | beforeEach(async () => {
| ^
17 | wsProvider = await new WsProvider(
18 | 'wss://kusama.api.onfinality.io/public-ws',
19 | ).isReady;
at packages/node/src/indexer/x-provider/x-provider.spec.ts:16:3
at Object.<anonymous> (packages/node/src/indexer/x-provider/x-provider.spec.ts:12:1)
● ApiPromiseConnection › should not cache requests if there are no args
expect(jest.fn()).toHaveBeenCalledTimes(expected)
Expected number of calls: 2
Received number of calls: 0
76 | const result2 = await cachedProvider.send('chain_getHeader', []);
77 |
> 78 | expect(httpProvider.send).toHaveBeenCalledTimes(2);
| ^
79 | expect(result1).not.toEqual(result2);
80 | }, 10000);
81 | });
at Object.<anonymous> (packages/node/src/indexer/x-provider/x-provider.spec.ts:78:31)
● Cli publish › should upload appropriate project to IPFS
Publish project to default IPFS failed
172 | const results = ipfsWrite.addAll(contents, {pin: true, cidVersion: 0, wrapWithDirectory: isMultichain});
173 | for await (const result of results) {
> 174 | fileCidMap.set(result.path, result.cid.toString());
| ^
175 |
176 | await ipfsWrite.pin.remote.add(result.cid, {service: PIN_SERVICE}).catch((e) => {
177 | console.warn(
at packages/cli/src/controller/publish-controller.ts:174:15
at async Promise.all (index 0)
at async uploadFile (packages/cli/src/controller/publish-controller.ts:177:30)
at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:100:26)
at async /home/runner/work/subql/subql/packages/cli/src/controller/publish-controller.ts:105:26
at async Promise.all (index 1)
at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:103:9)
at async uploadToIpfs (packages/cli/src/controller/publish-controller.ts:70:28)
at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:33:21)
Cause:
HTTPError: <html>
<head><title>403 Forbidden</title></head>
<body>
<center><h1>403 Forbidden</h1></center>
<hr><center>nginx/1.17.7</center>
</body>
</html>
175 |
176 | await ipfsWrite.pin.remote.add(result.cid, {service: PIN_SERVICE}).catch((e) => {
> 177 | console.warn(
| ^
178 | `Failed to pin file ${result.path}. There might be problems with this file being accessible later. ${e}`
179 | );
180 | });
at Object.errorHandler [as handleError] (node_modules/ipfs-http-client/cjs/src/lib/core.js:84:15)
at async Client.fetch (node_modules/ipfs-http-client/node_modules/ipfs-utils/src/http.js:161:9)
at async addAll (node_modules/ipfs-http-client/cjs/src/add-all.js:21:17)
at async Object.last [as default] (node_modules/it-last/index.js:13:20)
at async Object.add (node_modules/ipfs-http-client/cjs/src/add.js:18:14)
at async Promise.all (index 0)
at async uploadFile (packages/cli/src/controller/publish-controller.ts:177:30)
at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:100:26)
at async /home/runner/work/subql/subql/packages/cli/src/controller/publish-controller.ts:105:26
at async Promise.all (index 1)
at async replaceFileReferences (packages/cli/src/controller/publish-controller.ts:103:9)
at async uploadToIpfs (packages/cli/src/controller/publish-controller.ts:70:28)
at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:33:21)
● Intergration test - Publish › overwrites any exisiting CID files
thrown: "Exceeded timeout of 300000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
28 | it('overwrites any exisiting CID files', async () => {
29 | const initCID = 'QmWLxg7xV7ZWUyc7ZxZ8XuQQ7NmH8WQGXzg7VZ3QQNqF-testing';
> 30 | const cidFilePath = path.resolve(projectDir, '.project-cid');
| ^
31 | await fs.promises.writeFile(cidFilePath, initCID);
32 | await Publish.run(['-f', projectDir, '-o']);
33 | const cidValue = await fs.promises.readFile(cidFilePath, 'utf8');
at packages/cli/src/commands/publish.test.ts:30:5
at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:15:1)
● Intergration test - Publish › create ipfsCID file stored in local with dictiory path
thrown: "Exceeded timeout of 300000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
36 |
37 | it('create ipfsCID file stored in local with dictiory path', async () => {
> 38 | await Publish.run(['-f', projectDir]);
| ^
39 | const cidFile = path.resolve(projectDir, '.project-cid');
40 | const fileExists = fs.existsSync(cidFile);
41 | const IPFScontent = await fs.promises.readFile(cidFile, 'utf8');
at packages/cli/src/commands/publish.test.ts:38:5
at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:15:1)
● Intergration test - Publish › file name consistent with manfiest file name, if -f <manifest path> is used
thrown: "Exceeded timeout of 300000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
45 |
46 | // Run this last because it modifies the project
> 47 | it('file name consistent with manfiest file name, if -f <manifest path> is used', async () => {
| ^
48 | const manifestPath = path.resolve(projectDir, 'project.yaml');
49 | const testManifestPath = path.resolve(projectDir, 'test.yaml');
50 | fs.renameSync(manifestPath, testManifestPath);
at packages/cli/src/commands/publish.test.ts:47:5
at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:15:1)
Report generated by 🧪jest coverage report action from 5e5aa12
stwiname
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Enable ts strict mode in common package
Type of change
Please delete options that are not relevant.
Checklist